Skip to content

Commit

Permalink
Issue 30220 sidebar UI workflow general work (#30553)
Browse files Browse the repository at this point in the history
This pull request includes several changes to the
`dot-edit-content-aside` components, focusing on the removal of the
`dot-content-aside-information` component and its associated styles,
tests, and dependencies. Additionally, there are minor updates to the
`dot-workflow.model.ts` and `_chip.scss` files.

### Removal of `dot-content-aside-information` component:

*
[`dot-content-aside-information.component.html`](diffhunk://#diff-6adc68e2d95a821f4d8925e0239674b67e89e02c5cdd839bcfa7a0c49d5b9b78L1-L89):
Removed the entire HTML structure for the
`dot-content-aside-information` component.
*
[`dot-content-aside-information.component.scss`](diffhunk://#diff-2bf8e19b4d4c9b0c44f8c970cee01eb233e9a21e1f37e7abff2cc59378ac8da7L1-L138):
Removed all SCSS styles associated with the
`dot-content-aside-information` component.
*
[`dot-content-aside-information.component.spec.ts`](diffhunk://#diff-7ddd370c43dd17ebd5c088a57d87c8651634e08e684bb7627ca90df6a4f2a7e2L1-L199):
Removed the test file for the `dot-content-aside-information` component.
*
[`dot-content-aside-information.component.ts`](diffhunk://#diff-bd3fe321d996861e14eb9eb1a2fee6dec7f41bbf2173033bf2b6f0040a3b3eccL1-L42):
Removed the TypeScript file for the `dot-content-aside-information`
component, including all imports and component definitions.

### Minor updates:

*
[`dot-workflow.model.ts`](diffhunk://#diff-acd1926d0e077b455d7b9d20d392361f749da625e6c0978cf7f0f4427a4a1cc9R12):
Added an optional `variableName` property to the `DotCMSWorkflow`
interface.
*
[`_chip.scss`](diffhunk://#diff-864f8377caaa673a5f527e429f3c8d8de0584eaca07bb5dad3eebb3cbd2f91a1L197-R197):
Changed the height of the `p-chip` class from `$field-height-sm` to
`$font-size-xl`.

### Checklist
- [x] Tests
- [x] Translations
- [ ] Security Implications Contemplated (add notes if applicable)

### Additional Info
** any additional useful context or info **

### Screenshots



https://github.com/user-attachments/assets/b87f95ae-0ca9-44a2-8162-d238a01ca663
  • Loading branch information
oidacra authored Nov 6, 2024
1 parent 8077c29 commit 4271248
Show file tree
Hide file tree
Showing 47 changed files with 1,740 additions and 1,068 deletions.
1 change: 1 addition & 0 deletions core-web/libs/dotcms-models/src/lib/dot-workflow.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export interface DotCMSWorkflow {
modDate: Date;
name: string;
system: boolean;
variableName?: string;
}

export interface DotWorkflowPayload {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ p-chip .p-chip {
padding: 0 $spacing-1;
border-radius: $border-radius-sm;
font-size: $font-size-sm;
height: $field-height-sm;
height: $font-size-xl;

.p-chip-text {
font-size: $font-size-sm;
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 4271248

Please sign in to comment.