Skip to content

Commit

Permalink
dev: cover tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@rjvelazco
rjvelazco committed Aug 21, 2024
1 parent 5743490 commit 3c29963
Show file tree
Hide file tree
Showing 8 changed files with 230 additions and 156 deletions.
3 changes: 2 additions & 1 deletion ...-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ describe('DotEmaShellComponent', () => {
{
icon: 'pi-ellipsis-v',
label: 'editema.editor.navbar.properties',
id: 'properties'
id: 'properties',
isDisabled: false
}
]);
});
Expand Down
66 changes: 38 additions & 28 deletions .../libs/portlets/edit-ema/portlet/src/lib/edit-ema-layout/edit-ema-layout.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
DotRouterService
} from '@dotcms/data-access';
import { CoreWebService, LoginService } from '@dotcms/dotcms-js';
import { DotPageRender } from '@dotcms/dotcms-models';
import { TemplateBuilderComponent, TemplateBuilderModule } from '@dotcms/template-builder';
import {
DotExperimentsServiceMock,
Expand All @@ -33,8 +34,36 @@ import { EditEmaLayoutComponent } from './edit-ema-layout.component';

import { DotActionUrlService } from '../services/dot-action-url/dot-action-url.service';
import { DotPageApiService } from '../services/dot-page-api.service';
import { UVE_STATUS } from '../shared/enums';
import { UVEStore } from '../store/dot-uve.store';

const PAGE_RESPONSE = {
containers: {},
page: {
identifier: 'test'
},
template: {
theme: 'testTheme'
},
layout: {
body: {
rows: [
{
columns: [
{
containers: [
{
identifier: 'test'
}
]
}
]
}
]
}
}
};

describe('EditEmaLayoutComponent', () => {
let spectator: Spectator<EditEmaLayoutComponent>;
let component: EditEmaLayoutComponent;
Expand Down Expand Up @@ -72,32 +101,7 @@ describe('EditEmaLayoutComponent', () => {
provide: DotPageApiService,
useValue: {
get: () => {
return of({
containers: {},
page: {
identifier: 'test'
},
template: {
theme: 'testTheme'
},
layout: {
body: {
rows: [
{
columns: [
{
containers: [
{
identifier: 'test'
}
]
}
]
}
]
}
}
});
return of(PAGE_RESPONSE);
}
}
},
Expand Down Expand Up @@ -136,7 +140,7 @@ describe('EditEmaLayoutComponent', () => {
spectator = createComponent();
component = spectator.component;
dotRouter = spectator.inject(DotRouterService);
store = spectator.inject(UVEStore);
store = spectator.inject(UVEStore, true);
layoutService = spectator.inject(DotPageLayoutService);
messageService = spectator.inject(MessageService);

Expand Down Expand Up @@ -166,12 +170,18 @@ describe('EditEmaLayoutComponent', () => {
});

it('should trigger a save after 5 secs', fakeAsync(() => {
const layoutServiceSave = jest.spyOn(layoutService, 'save');
const layoutServiceSave = jest
.spyOn(layoutService, 'save')
.mockReturnValue(of(PAGE_RESPONSE as unknown as DotPageRender));
const updatePageResponseSpy = jest.spyOn(store, 'updatePageResponse');
const setUveStatusSpy = jest.spyOn(store, 'setUveStatus');

templateBuilder.templateChange.emit();
tick(5000);

expect(layoutServiceSave).toHaveBeenCalled();
expect(updatePageResponseSpy).toHaveBeenCalledWith(PAGE_RESPONSE);
expect(setUveStatusSpy).toHaveBeenCalledWith(UVE_STATUS.LOADING);

expect(addMock).toHaveBeenNthCalledWith(1, {
severity: 'info',
Expand Down
3 changes: 1 addition & 2 deletions core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-layout/edit-ema-layout.component.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ export class EditEmaLayoutComponent implements OnInit, OnDestroy {
*
* @private
* @template T
* // To not get the error of the type with DotPageRender and DotPageApiResponse
* @param {T=unkonwm} page
* @param {T=unkonwm} page // To avoid getting type error with DotPageRender and DotPageApiResponse
* @memberof EditEmaLayoutComponent
*/
private handleSuccessSaveTemplate<T = unknown>(page: T): void {
Expand Down
83 changes: 43 additions & 40 deletions core-web/libs/portlets/edit-ema/portlet/src/lib/shared/mocks.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,48 @@ export const ACTION_PAYLOAD_MOCK: ActionPayload = {
position: 'after'
};

export const BASE_SHELL_ITEMS = [
{
icon: 'pi-file',
label: 'editema.editor.navbar.content',
href: 'content',
id: 'content'
},
{
icon: 'pi-table',
label: 'editema.editor.navbar.layout',
href: 'layout',
id: 'layout',
isDisabled: false,
tooltip: null
},
{
icon: 'pi-sliders-h',
label: 'editema.editor.navbar.rules',
id: 'rules',
href: `rules/${MOCK_RESPONSE_HEADLESS.page.identifier}`,
isDisabled: false
},
{
iconURL: 'experiments',
label: 'editema.editor.navbar.experiments',
href: `experiments/${MOCK_RESPONSE_HEADLESS.page.identifier}`,
id: 'experiments',
isDisabled: false
},
{
icon: 'pi-th-large',
label: 'editema.editor.navbar.page-tools',
id: 'page-tools'
},
{
icon: 'pi-ellipsis-v',
label: 'editema.editor.navbar.properties',
id: 'properties',
isDisabled: false
}
];

export const BASE_SHELL_PROPS_RESPONSE = {
canRead: true,
error: null,
Expand All @@ -683,46 +725,7 @@ export const BASE_SHELL_PROPS_RESPONSE = {
currentUrl: '/test-url',
requestHostName: 'http://localhost:3000'
},
items: [
{
icon: 'pi-file',
label: 'editema.editor.navbar.content',
href: 'content',
id: 'content'
},
{
icon: 'pi-table',
label: 'editema.editor.navbar.layout',
href: 'layout',
id: 'layout',
isDisabled: false,
tooltip: null
},
{
icon: 'pi-sliders-h',
label: 'editema.editor.navbar.rules',
id: 'rules',
href: `rules/${MOCK_RESPONSE_HEADLESS.page.identifier}`,
isDisabled: false
},
{
iconURL: 'experiments',
label: 'editema.editor.navbar.experiments',
href: `experiments/${MOCK_RESPONSE_HEADLESS.page.identifier}`,
id: 'experiments',
isDisabled: false
},
{
icon: 'pi-th-large',
label: 'editema.editor.navbar.page-tools',
id: 'page-tools'
},
{
icon: 'pi-ellipsis-v',
label: 'editema.editor.navbar.properties',
id: 'properties'
}
]
items: BASE_SHELL_ITEMS
};

export const UVE_PAGE_RESPONSE_MAP = {
Expand Down
41 changes: 39 additions & 2 deletions core-web/libs/portlets/edit-ema/portlet/src/lib/store/dot-uve.store.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import { EDITOR_STATE, UVE_STATUS } from '../shared/enums';
import {
ACTION_MOCK,
ACTION_PAYLOAD_MOCK,
BASE_SHELL_ITEMS,
BASE_SHELL_PROPS_RESPONSE,
EMA_DRAG_ITEM_CONTENTLET_MOCK,
getBoundsMock,
Expand Down Expand Up @@ -166,6 +167,23 @@ describe('UVEStore', () => {
it('should return the shell props for Headless Pages', () => {
expect(store.$shellProps()).toEqual(BASE_SHELL_PROPS_RESPONSE);
});
it('should return the shell props with property item disable when loading', () => {
store.setUveStatus(UVE_STATUS.LOADING);
const baseItems = BASE_SHELL_ITEMS.slice(0, BASE_SHELL_ITEMS.length - 1);

expect(store.$shellProps()).toEqual({
...BASE_SHELL_PROPS_RESPONSE,
items: [
...baseItems,
{
icon: 'pi-ellipsis-v',
label: 'editema.editor.navbar.properties',
id: 'properties',
isDisabled: true
}
]
});
});
it('should return the error for 404', () => {
patchState(store, { errorCode: 404 });

Expand Down Expand Up @@ -258,7 +276,8 @@ describe('UVEStore', () => {
{
icon: 'pi-ellipsis-v',
label: 'editema.editor.navbar.properties',
id: 'properties'
id: 'properties',
isDisabled: false
}
]
});
Expand Down Expand Up @@ -337,6 +356,23 @@ describe('UVEStore', () => {
expect(store.status()).toBe(UVE_STATUS.LOADING);
});
});

describe('updatePageResponse', () => {
it('should update the page response', () => {
const pageAPIResponse = {
...MOCK_RESPONSE_HEADLESS,
page: {
...MOCK_RESPONSE_HEADLESS.page,
title: 'New title'
}
};

store.updatePageResponse(pageAPIResponse);

expect(store.pageAPIResponse()).toEqual(pageAPIResponse);
expect(store.status()).toBe(UVE_STATUS.LOADED);
});
});
});

describe('withLoad', () => {
Expand Down Expand Up @@ -556,7 +592,8 @@ describe('UVEStore', () => {
layout: MOCK_RESPONSE_HEADLESS.layout,
template: {
identifier: MOCK_RESPONSE_HEADLESS.template.identifier,
themeId: MOCK_RESPONSE_HEADLESS.template.theme
themeId: MOCK_RESPONSE_HEADLESS.template.theme,
anonymous: false
},
pageId: MOCK_RESPONSE_HEADLESS.page.identifier
});
Expand Down
2 changes: 1 addition & 1 deletion core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/layout/models.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export interface LayoutProps {
template: {
identifier: string;
themeId: string;
anonymous: boolean;
anonymous?: boolean;
};
pageId: string;
}
Loading

0 comments on commit 3c29963

Please sign in to comment.