#26310 Move DotFieldValidationMessageComponent to UI lib (#26315)

* #26310 move `DotFieldValidationMessageComponent` to UI lib * #26310 fix import component on test * #26310 fix import component on test
dotCMS · Oct 5, 2023 · 0b8d03f · 0b8d03f
1 parent 3084364
commit 0b8d03f
Show file tree

Hide file tree

Showing 53 changed files with 302 additions and 293 deletions.
diff --git a/core-web/apps/dotcms-ui/src/app/modules.ts b/core-web/apps/dotcms-ui/src/app/modules.ts
@@ -28,10 +28,9 @@ import { DotContentCompareModule } from '@components/dot-content-compare/dot-con
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotMessageDisplayModule } from '@components/dot-message-display/dot-message-display.module';
 import { DotToolbarModule } from '@components/dot-toolbar/dot-toolbar.module';
-import { DotIconModule } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotIconModule } from '@dotcms/ui';
 
 import { DotActionButtonModule } from './view/components/_common/dot-action-button/dot-action-button.module';
-import { DotFieldValidationMessageModule } from './view/components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotGenerateSecurePasswordModule } from './view/components/_common/dot-generate-secure-password/dot-generate-secure-password.module';
 import { DotSiteSelectorModule } from './view/components/_common/dot-site-selector/dot-site-selector.module';
 import { DotTextareaContentModule } from './view/components/_common/dot-textarea-content/dot-textarea-content.module';
@@ -51,7 +50,7 @@ export const CUSTOM_MODULES = [
     DotTextareaContentModule,
     DotWorkflowTaskDetailModule,
     DotMessageDisplayModule,
-    DotFieldValidationMessageModule,
+    DotFieldValidationMessageComponent,
     IFrameModule,
     DotListingDataTableModule,
     SearchableDropDownModule,

diff --git a/...p/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.component.spec.ts b/...p/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.component.spec.ts
@@ -10,13 +10,16 @@ import { MultiSelectModule } from 'primeng/multiselect';
 
 import { of } from 'rxjs/internal/observable/of';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotRouterService } from '@dotcms/app/api/services/dot-router/dot-router.service';
 import { DotPagesFavoritePageEmptySkeletonComponent } from '@dotcms/app/portlets/dot-pages/dot-pages-favorite-page-empty-skeleton/dot-pages-favorite-page-empty-skeleton.component';
 import { DotMessageService, DotSessionStorageService } from '@dotcms/data-access';
 import { CoreWebService, CoreWebServiceMock, LoginService } from '@dotcms/dotcms-js';
 import { DotPageRender, DotPageRenderState } from '@dotcms/dotcms-models';
-import { DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import {
     LoginServiceMock,
     MockDotMessageService,
@@ -134,7 +137,7 @@ describe('DotFavoritePageComponent', () => {
                 FormsModule,
                 MultiSelectModule,
                 ReactiveFormsModule,
-                DotFieldValidationMessageModule,
+                DotFieldValidationMessageComponent,
                 DotFieldRequiredDirective,
                 DotPagesFavoritePageEmptySkeletonComponent,
                 HttpClientTestingModule

diff --git a/...i/src/app/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.module.ts b/...i/src/app/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.module.ts
@@ -5,12 +5,16 @@ import { ReactiveFormsModule } from '@angular/forms';
 import { ButtonModule } from 'primeng/button';
 import { InputTextModule } from 'primeng/inputtext';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotFormDialogModule } from '@components/dot-form-dialog/dot-form-dialog.module';
 import { DotTempFileUploadService } from '@dotcms/app/api/services/dot-temp-file-upload/dot-temp-file-upload.service';
 import { DotPagesFavoritePageEmptySkeletonComponent } from '@dotcms/app/portlets/dot-pages/dot-pages-favorite-page-empty-skeleton/dot-pages-favorite-page-empty-skeleton.component';
 import { DotWorkflowActionsFireService } from '@dotcms/data-access';
-import { DotAutofocusDirective, DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotAutofocusDirective,
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 
 import { DotFavoritePageComponent } from './dot-favorite-page.component';
@@ -23,7 +27,7 @@ import { DotFavoritePageComponent } from './dot-favorite-page.component';
         ButtonModule,
         DotAutofocusDirective,
         DotFormDialogModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         DotPagesFavoritePageEmptySkeletonComponent,
         DotPipesModule,
         InputTextModule,

diff --git a/...emplates/dot-template-create-edit/dot-template-props/dot-template-props.component.spec.ts b/...emplates/dot-template-create-edit/dot-template-props/dot-template-props.component.spec.ts
@@ -12,9 +12,12 @@ import { By } from '@angular/platform-browser';
 
 import { DynamicDialogConfig, DynamicDialogRef } from 'primeng/dynamicdialog';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotMessageService } from '@dotcms/data-access';
-import { DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import { MockDotMessageService } from '@dotcms/utils-testing';
 
 import { DotTemplatePropsComponent } from './dot-template-props.component';
@@ -117,7 +120,7 @@ describe('DotTemplatePropsComponent', () => {
                 DotMessagePipe,
                 FormsModule,
                 ReactiveFormsModule,
-                DotFieldValidationMessageModule,
+                DotFieldValidationMessageComponent,
                 DotFieldRequiredDirective
             ],
             providers: [

diff --git a/...ts/dot-templates/dot-template-create-edit/dot-template-props/dot-template-props.module.ts b/...ts/dot-templates/dot-template-create-edit/dot-template-props/dot-template-props.module.ts
@@ -5,10 +5,13 @@ import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { InputTextModule } from 'primeng/inputtext';
 import { InputTextareaModule } from 'primeng/inputtextarea';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotFormDialogModule } from '@components/dot-form-dialog/dot-form-dialog.module';
 import { DotThemeSelectorDropdownModule } from '@components/dot-theme-selector-dropdown/dot-theme-selector-dropdown.module';
-import { DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 
 import { DotTemplatePropsComponent } from './dot-template-props.component';
 import { DotTemplateThumbnailFieldModule } from './dot-template-thumbnail-field/dot-template-thumbnail-field.module';
@@ -17,7 +20,7 @@ import { DotTemplateThumbnailFieldModule } from './dot-template-thumbnail-field/
     declarations: [DotTemplatePropsComponent],
     imports: [
         CommonModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         DotFormDialogModule,
         FormsModule,
         InputTextModule,

diff --git a/...ents/fields/content-type-fields-drop-zone/content-type-fields-drop-zone.component.spec.ts b/...ents/fields/content-type-fields-drop-zone/content-type-fields-drop-zone.component.spec.ts
@@ -27,7 +27,6 @@ import { TableModule } from 'primeng/table';
 import { TabViewModule } from 'primeng/tabview';
 
 import { DotActionButtonModule } from '@components/_common/dot-action-button/dot-action-button.module';
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotDialogActions, DotDialogComponent } from '@components/dot-dialog/dot-dialog.component';
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotMessageDisplayService } from '@components/dot-message-display/services';
@@ -41,7 +40,7 @@ import {
     DotCMSContentTypeLayoutRow,
     DotFieldVariable
 } from '@dotcms/dotcms-models';
-import { DotIconModule, DotMessagePipe } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotIconModule, DotMessagePipe } from '@dotcms/ui';
 import { DotLoadingIndicatorService } from '@dotcms/utils';
 import {
     cleanUpDialog,
@@ -212,7 +211,7 @@ describe('ContentTypeFieldsDropZoneComponent', () => {
                 DotIconModule,
                 DragulaModule,
                 TableModule,
-                DotFieldValidationMessageModule,
+                DotFieldValidationMessageComponent,
                 ReactiveFormsModule,
                 HttpClientTestingModule,
                 DotMessagePipe,
@@ -484,7 +483,6 @@ describe('Load fields and drag and drop', () => {
                     }
                 ]),
                 DragulaModule,
-                DotFieldValidationMessageModule,
                 DotContentTypeFieldsVariablesModule,
                 FormsModule,
                 CheckboxModule,

diff --git a/...ies-form/field-properties/default-value-property/default-value-property.component.spec.ts b/...ies-form/field-properties/default-value-property/default-value-property.component.spec.ts
@@ -8,9 +8,8 @@ import {
 } from '@angular/forms';
 import { By } from '@angular/platform-browser';
 
-import { DotFieldValidationMessageComponent } from '@components/_common/dot-field-validation-message/dot-field-validation-message';
 import { DotMessageService } from '@dotcms/data-access';
-import { DotMessagePipe } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotMessagePipe } from '@dotcms/ui';
 import { dotcmsContentTypeFieldBasicMock, MockDotMessageService } from '@dotcms/utils-testing';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 
@@ -30,8 +29,13 @@ describe('DefaultValuePropertyComponent', () => {
 
     beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
-            declarations: [DefaultValuePropertyComponent, DotFieldValidationMessageComponent],
-            imports: [ReactiveFormsModule, DotPipesModule, DotMessagePipe],
+            declarations: [DefaultValuePropertyComponent],
+            imports: [
+                ReactiveFormsModule,
+                DotPipesModule,
+                DotMessagePipe,
+                DotFieldValidationMessageComponent
+            ],
             providers: [{ provide: DotMessageService, useValue: messageServiceMock }]
         }).compileComponents();
 

diff --git a/...s-properties-form/field-properties/dot-relationships-property/dot-relationships.module.ts b/...s-properties-form/field-properties/dot-relationships-property/dot-relationships.module.ts
@@ -5,9 +5,12 @@ import { FormsModule } from '@angular/forms';
 import { DropdownModule } from 'primeng/dropdown';
 import { RadioButtonModule } from 'primeng/radiobutton';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { SearchableDropDownModule } from '@components/_common/searchable-dropdown';
-import { DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 
 import { DotCardinalitySelectorComponent } from './dot-cardinality-selector/dot-cardinality-selector.component';
@@ -28,7 +31,7 @@ import { DotRelationshipService } from './services/dot-relationship.service';
     imports: [
         CommonModule,
         DropdownModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         FormsModule,
         RadioButtonModule,
         SearchableDropDownModule,

diff --git a/...rtlets/shared/dot-content-types-edit/components/form/content-types-form.component.spec.ts b/...rtlets/shared/dot-content-types-edit/components/form/content-types-form.component.spec.ts
@@ -21,7 +21,6 @@ import { InputTextModule } from 'primeng/inputtext';
 import { OverlayPanelModule } from 'primeng/overlaypanel';
 import { TabViewModule } from 'primeng/tabview';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotPageSelectorModule } from '@components/_common/dot-page-selector/dot-page-selector.module';
 import { DotWorkflowsActionsSelectorFieldModule } from '@components/_common/dot-workflows-actions-selector-field/dot-workflows-actions-selector-field.module';
 import { DotWorkflowsSelectorFieldModule } from '@components/_common/dot-workflows-selector-field/dot-workflows-selector-field.module';
@@ -38,7 +37,7 @@ import {
 } from '@dotcms/data-access';
 import { DotcmsConfigService, LoginService, SiteService } from '@dotcms/dotcms-js';
 import { DotCMSContentTypeLayoutRow, DotCMSSystemActionType } from '@dotcms/dotcms-models';
-import { DotIconModule, DotMessagePipe } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotIconModule, DotMessagePipe } from '@dotcms/ui';
 import {
     dotcmsContentTypeBasicMock,
     dotcmsContentTypeFieldBasicMock,
@@ -165,7 +164,7 @@ describe('ContentTypesFormComponent', () => {
                 ButtonModule,
                 DotDirectivesModule,
                 DotFieldHelperModule,
-                DotFieldValidationMessageModule,
+                DotFieldValidationMessageComponent,
                 DotIconModule,
                 DotPageSelectorModule,
                 DotWorkflowsActionsSelectorFieldModule,

diff --git a/...dotcms-ui/src/app/portlets/shared/dot-content-types-edit/dot-content-types-edit.module.ts b/...dotcms-ui/src/app/portlets/shared/dot-content-types-edit/dot-content-types-edit.module.ts
@@ -18,7 +18,6 @@ import { TabViewModule } from 'primeng/tabview';
 import { TooltipModule } from 'primeng/tooltip';
 
 import { DotAddToBundleModule } from '@components/_common/dot-add-to-bundle';
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotInlineEditModule } from '@components/_common/dot-inline-edit/dot-inline-edit.module';
 import { DotMenuModule } from '@components/_common/dot-menu/dot-menu.module';
 import { DotPageSelectorModule } from '@components/_common/dot-page-selector/dot-page-selector.module';
@@ -43,6 +42,7 @@ import { DotContentTypesInfoService, DotWorkflowService } from '@dotcms/data-acc
 import {
     DotAutofocusDirective,
     DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
     DotIconModule,
     DotMessagePipe
 } from '@dotcms/ui';
@@ -130,7 +130,7 @@ import { DotAddToMenuModule } from '../dot-content-types-listing/components/dot-
         DotPipesModule,
         DotSecondaryToolbarModule,
         DotFieldHelperModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         TooltipModule,
         DotIconModule,
         DotMaxlengthModule,

diff --git a/...ed/dot-content-types-listing/components/dot-add-to-menu/dot-add-to-menu.component.spec.ts b/...ed/dot-content-types-listing/components/dot-add-to-menu/dot-add-to-menu.component.spec.ts
@@ -12,7 +12,6 @@ import { DropdownModule } from 'primeng/dropdown';
 import { InputTextModule } from 'primeng/inputtext';
 import { RadioButtonModule } from 'primeng/radiobutton';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotMenuServiceMock } from '@components/dot-navigation/services/dot-navigation.service.spec';
 import {
@@ -22,7 +21,7 @@ import {
 import { DotMenuService } from '@dotcms/app/api/services/dot-menu.service';
 import { DotMessageService } from '@dotcms/data-access';
 import { CoreWebService } from '@dotcms/dotcms-js';
-import { DotMessagePipe } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotMessagePipe } from '@dotcms/ui';
 import {
     CoreWebServiceMock,
     dotcmsContentTypeBasicMock,
@@ -103,7 +102,7 @@ describe('DotAddToMenuComponent', () => {
                 DotPipesModule,
                 DotMessagePipe,
                 HttpClientTestingModule,
-                DotFieldValidationMessageModule
+                DotFieldValidationMessageComponent
             ],
             providers: [
                 { provide: CoreWebService, useClass: CoreWebServiceMock },

diff --git a/...ets/shared/dot-content-types-listing/components/dot-add-to-menu/dot-add-to-menu.module.ts b/...ets/shared/dot-content-types-listing/components/dot-add-to-menu/dot-add-to-menu.module.ts
@@ -6,12 +6,16 @@ import { DropdownModule } from 'primeng/dropdown';
 import { InputTextModule } from 'primeng/inputtext';
 import { RadioButtonModule } from 'primeng/radiobutton';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotNavigationService } from '@components/dot-navigation/services/dot-navigation.service';
 import { DotAddToMenuService } from '@dotcms/app/api/services/add-to-menu/add-to-menu.service';
 import { DotMenuService } from '@dotcms/app/api/services/dot-menu.service';
-import { DotAutofocusDirective, DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotAutofocusDirective,
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 
 import { DotAddToMenuComponent } from './dot-add-to-menu.component';
@@ -23,7 +27,7 @@ import { DotAddToMenuComponent } from './dot-add-to-menu.component';
         CommonModule,
         DotAutofocusDirective,
         DotDialogModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         DotPipesModule,
         DropdownModule,
         InputTextModule,

diff --git a/...ng/components/dot-content-type-copy-dialog/dot-content-type-copy-dialog.component.spec.ts b/...ng/components/dot-content-type-copy-dialog/dot-content-type-copy-dialog.component.spec.ts
@@ -7,13 +7,12 @@ import { ReactiveFormsModule } from '@angular/forms';
 import { By } from '@angular/platform-browser';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotMdIconSelectorModule } from '@components/_common/dot-md-icon-selector/dot-md-icon-selector.module';
 import { SiteSelectorFieldModule } from '@components/_common/dot-site-selector-field/dot-site-selector-field.module';
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotEventsService, DotMessageService } from '@dotcms/data-access';
 import { CoreWebService, SiteService } from '@dotcms/dotcms-js';
-import { DotMessagePipe } from '@dotcms/ui';
+import { DotFieldValidationMessageComponent, DotMessagePipe } from '@dotcms/ui';
 import { CoreWebServiceMock, MockDotMessageService, SiteServiceMock } from '@dotcms/utils-testing';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 import { DotFormSelectorModule } from '@portlets/dot-edit-page/content/components/dot-form-selector/dot-form-selector.module';
@@ -55,7 +54,7 @@ describe('DotContentTypeCloneDialogComponent', () => {
             imports: [
                 DotFormSelectorModule,
                 BrowserAnimationsModule,
-                DotFieldValidationMessageModule,
+                DotFieldValidationMessageComponent,
                 DotMdIconSelectorModule,
                 SiteSelectorFieldModule,
                 DotDialogModule,

diff --git a/...es-listing/components/dot-content-type-copy-dialog/dot-content-type-copy-dialog.module.ts b/...es-listing/components/dot-content-type-copy-dialog/dot-content-type-copy-dialog.module.ts
@@ -4,13 +4,17 @@ import { ReactiveFormsModule } from '@angular/forms';
 
 import { InputTextModule } from 'primeng/inputtext';
 
-import { DotFieldValidationMessageModule } from '@components/_common/dot-field-validation-message/dot-file-validation-message.module';
 import { DotMdIconSelectorModule } from '@components/_common/dot-md-icon-selector/dot-md-icon-selector.module';
 import { SiteSelectorFieldModule } from '@components/_common/dot-site-selector-field/dot-site-selector-field.module';
 import { DotBaseTypeSelectorModule } from '@components/dot-base-type-selector';
 import { DotDialogModule } from '@components/dot-dialog/dot-dialog.module';
 import { DotListingDataTableModule } from '@components/dot-listing-data-table';
-import { DotAutofocusDirective, DotFieldRequiredDirective, DotMessagePipe } from '@dotcms/ui';
+import {
+    DotAutofocusDirective,
+    DotFieldRequiredDirective,
+    DotFieldValidationMessageComponent,
+    DotMessagePipe
+} from '@dotcms/ui';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 
 import { DotContentTypeCopyDialogComponent } from './dot-content-type-copy-dialog.component';
@@ -23,7 +27,7 @@ import { DotContentTypeCopyDialogComponent } from './dot-content-type-copy-dialo
         DotListingDataTableModule,
         DotBaseTypeSelectorModule,
         DotPipesModule,
-        DotFieldValidationMessageModule,
+        DotFieldValidationMessageComponent,
         DotDialogModule,
         DotMdIconSelectorModule,
         SiteSelectorFieldModule,