dotCMS/core#20153 fix rules-deactivating-on-valid-actions (#1689)

dotCMS · Jun 30, 2021 · b53547c · b53547c
1 parent cf277b7
commit b53547c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/libs/dot-rules/src/lib/rule-engine.container.ts b/libs/dot-rules/src/lib/rule-engine.container.ts
@@ -606,8 +606,8 @@ export class RuleEngineContainer implements OnDestroy {
     }
 
     patchAction(rule: RuleModel, ruleAction: ActionModel): void {
-        this.ruleUpdating(rule);
         if (ruleAction.isValid()) {
+            this.ruleUpdating(rule, false);
             if (!ruleAction.isPersisted()) {
                 this._ruleActionService.createRuleAction(rule.key, ruleAction).subscribe(
                     (_) => {
@@ -630,6 +630,7 @@ export class RuleEngineContainer implements OnDestroy {
                 );
             }
         } else {
+            this.ruleUpdating(rule);
             this.ruleUpdated(rule, {
                 invalid: 'Cannot save, action is not valid.'
             });