SequenceSearchDef: report file search progress on debug log #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
reviewed
May 9, 2024
searchkit/search.py
Outdated
| # NOTE: line numbers start at 1 hence offset + 1 | ||
| for ln, line in enumerate(fd, start=offset + 1): | ||
| # This could be helpful to show progress for large files | ||
| if ln % 100000 == 0: | ||
| log.debug("%s lines searched in %s", ln, fd.name) | ||
| log.debug("%s lines searched in %s (%g%%)", |
There was a problem hiding this comment.
can we round the pcent to 3 dp e.g. {0:.3f}
There was a problem hiding this comment.
done:
2024-05-09 15:21:00,860 544680 DEBUG searchkit [-] 200000 lines searched in openstackrgxrh5t2/tmpry787c7r (55.455%)
2024-05-09 15:21:00,947 544681 DEBUG searchkit [-] 300000 lines searched in openstackrgxrh5t2/tmpcqx172jh (82.786%)
2024-05-09 15:21:00,954 544680 DEBUG searchkit [-] 300000 lines searched in openstackrgxrh5t2/tmpry787c7r (82.786%)
searchkit/search.py
Outdated
| log.debug("starting search of %s (offset=%s, pos=%s)", fd.name, offset, | ||
| fd.tell()) | ||
| log.debug("starting search of %s (offset=%s, pos=%s) for tags [%s]", | ||
| fd.name, offset, fd.tell(), search_tags) |
There was a problem hiding this comment.
it is nice to see the tags but maybe we need to format it differently to make it readable since it will be a very very long line otherwise.
There was a problem hiding this comment.
done:
2024-05-09 15:20:57,660 544681 DEBUG searchkit [-] starting search of /workspace/case-data/test/sosreport-juju-4b6be0-3-lxd-13-00359298-2023-05-02-tiaplar/var/log/neutron/neutron-server.log.1 (offset=0, pos=0) for tags [[
"openstack.neutron.ovn_stale_db.checks.has_1829109_neutron_log.check.search",
"openstack.neutron.bugs.lp1948466.checks.has_1948466.check.search",
"openstack.neutron.bugs.lp1980211.checks.has_ovsdb_reconnection_errors.check.search",
"openstack.neutron.bugs.lp1960319.checks.has_1960319_log.check.search",
"openstack.neutron.bugs.lp1993628.checks.logs.check.search",
"openstack.neutron.ovndb_leader_bouncing.checks.has_nbdb_log.check.search",
"openstack.neutron.ovndb_leader_bouncing.checks.has_sbdb_log.check.search"
]]
mustafakemalgilor
force-pushed
the
enhancement/debug-file-search-progress
branch
3 times, most recently
from
0337068
to
a053a45
Compare
mustafakemalgilor
force-pushed
the
enhancement/debug-file-search-progress
branch
4 times, most recently
from
7a6c769
to
4e8542c
Compare
shorten the search file name to just parent_folder/filename and also print the search def tags before the search, so we can tell which search is currently being run. Signed-off-by: Mustafa Kemal Gilor <[email protected]>
mustafakemalgilor
force-pushed
the
enhancement/debug-file-search-progress
branch
from
4e8542c
to
31f8c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shorten the search file name to just parent_folder/filename and also print the search def tags before the search, so we can tell which search is currently being run.
Example log output: