Fix for timestamp seconds count on 4.20 kernel. #139

terraluna977 · 2018-11-08T00:04:10Z

Signed-off-by: Woody Suwalski [email protected]

Signed-off-by: Woody Suwalski <[email protected]>

tommyjcarpenter · 2018-12-31T12:58:47Z

I tried building your local branch @terraluna977 on arch 4.20 and it still fails to compile with many errors like the below

    /home/tommy/exfat-nofuse/exfat_super.c: In function ‘exfat_read_root’:
/home/tommy/exfat-nofuse/exfat_super.c:2425:18: error: wrong type argument to increment
  inode->i_version++;

Rirush · 2018-12-31T14:35:06Z

exfat_oal.c

@@ -128,16 +128,16 @@ static time_t accum_days_in_year[] = {

 TIMESTAMP_T *tm_current(TIMESTAMP_T *tp)
 {
-	struct timespec ts;
 	time_t second, day, leap_day, month, year;

 #if LINUX_VERSION_CODE < KERNEL_VERSION(4,8,0)


ktime_get_real_seconds() available on Linux kernels lower than 4.8.0 (looks like it was introduced in 3.19.0), is this #if really required at all?

as an FYI I have a working (built and tested this morning_ PR here: barrybingo#1

jamesan · 2019-01-07T06:23:15Z

Duplicate of #137.

Also, this doesn't address the root issue, which is updating to current time interfaces. The relevant deprecated time interfaces were finally removed from the Linux kernel on Aug 14, 2018 to address the Year 2038 problem by moving from 32- to 64-bit data types.

The official direct replacements for the timespec type and the ktime_get_real_ts() function are, respectively, timespec64 and ktime_get_real_ts64(), as found in Documentation/core-api/timekeeping.rst.

Fix for timestamp seconds count on 4.20 kernel.

988c9f7

Signed-off-by: Woody Suwalski <[email protected]>

Rirush reviewed Dec 31, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for timestamp seconds count on 4.20 kernel. #139

Fix for timestamp seconds count on 4.20 kernel. #139

terraluna977 commented Nov 8, 2018

tommyjcarpenter commented Dec 31, 2018 •

edited

Loading

Rirush Dec 31, 2018

tommyjcarpenter Dec 31, 2018

jamesan commented Jan 7, 2019 •

edited

Loading

Fix for timestamp seconds count on 4.20 kernel. #139

Are you sure you want to change the base?

Fix for timestamp seconds count on 4.20 kernel. #139

Conversation

terraluna977 commented Nov 8, 2018

tommyjcarpenter commented Dec 31, 2018 • edited Loading

Rirush Dec 31, 2018

Choose a reason for hiding this comment

tommyjcarpenter Dec 31, 2018

Choose a reason for hiding this comment

jamesan commented Jan 7, 2019 • edited Loading

tommyjcarpenter commented Dec 31, 2018 •

edited

Loading

jamesan commented Jan 7, 2019 •

edited

Loading