Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page for the 2016 DORA Report #706

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Conversation

nathenharvey
Copy link
Collaborator

@nathenharvey nathenharvey commented Jul 31, 2024

  • Add tests for 2016 report page
  • Add tests for new redirects
  • Refactor tests for /publications and add tests for each report
  • Add a 2016 report landing page /research/2016
  • Link to the new landing page from /publications
  • Link to the new landing page from /research/2017-and-earlier/

Preview links:

This supports #698

Signed-off-by: Nathen Harvey <[email protected]>
Following newly established patterns such as

* isolating tests
* checking that links are correct using `toHaveAttribute` and inspecting the `url`

Signed-off-by: Nathen Harvey <[email protected]>
Stop going directly to cgc so that users can select a language if they'd like to.

Signed-off-by: Nathen Harvey <[email protected]>
This supports #698

Signed-off-by: Nathen Harvey <[email protected]>
@dora-machine-user
Copy link
Collaborator

dora-machine-user commented Jul 31, 2024

Cloud Build time: Wed Jul 31 14:36:32 UTC 2024
Preview this PR [with drafts on] at https://doradotdev-staging--pr706-drafts-on-acvs5xc6.web.app
Preview this PR [with drafts off] at https://doradotdev-staging--pr706-drafts-off-pttjo3so.web.app

@nathenharvey nathenharvey marked this pull request as ready for review July 31, 2024 03:07
This updates capabilities and static content to point to the new location.

Redirects are in place to catch any theat we missed.

Signed-off-by: Nathen Harvey <[email protected]>
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG -- a couple nits

hugo/content/research/2016/_index.md Outdated Show resolved Hide resolved
* Fixes two typos
* Removes an extraneous paragraph in the summary

Signed-off-by: Nathen Harvey <[email protected]>
Copy link
Collaborator

@davidstanke davidstanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidstanke davidstanke merged commit 90faf87 into main Jul 31, 2024
2 checks passed
@davidstanke davidstanke deleted the 698-summarize-2016-report branch July 31, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants