Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf #22

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf #22

wants to merge 1 commit into from
+42 −34

Conversation

jasugun
Copy link
Contributor

@jasugun jasugun commented Nov 23, 2021

Rework how we load nimp conf files:

  • Set is_unreal if .nimp conf file is detected in unreal base path
  • Load legacy generic nimp conf first (if no unreal detected, or unreal <= 4.24)
  • Load monorepo conf if monorepo unreal is detected
  • Monorepo conf consists of base xpj .nimp.conf, overridable by specific uproject conf
  • Temporarily maintain deprecated xpj .baseNimp.conf (so we have time to replace them by .nimp.conf files)

@tdesveaux tdesveaux self-requested a review November 24, 2021 12:05
samhocevar
samhocevar approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@samhocevar samhocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.

@tdesveaux tdesveaux removed their request for review November 25, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhocevar samhocevar samhocevar approved these changes

@tdesveaux tdesveaux Awaiting requested review from tdesveaux

@ftith ftith Awaiting requested review from ftith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasugun @samhocevar