Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bottom up implementation #229

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Feb 24, 2018

  1. Refactor code

    Inputs don't need to be sorted, but we have to change how the bottom up implementation populates the results array.
    
    We can also simplify some of the statements by:
    
    1) removing the call to list when we create the list 'items', as there's no need for it;
    2) initializing the list items with zeros; and
    3) removing the if statement in the nested loop, since it's not necessary anymore because of donnemartin#2.
    
    We have to change the test too. We can't hardcode the labels to indices because they may be in a different position.
    rodferro committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    dd7cd3c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Fix a potential bug

    Range has to start at 1, otherwise, during the first row iteration, we're going to get values from the last row of table T (T[-1]).
    rodferro committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    cdf93bd View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2018

  1. Refactor insert method

    We can simplify the insert method by removing the nested conditionals.
    rodferro committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    37bb783 View commit details
    Browse the repository at this point in the history
  2. Revert "Refactor insert method"

    This reverts commit 37bb783.
    rodferro committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    0110698 View commit details
    Browse the repository at this point in the history
  3. Update authors

    rodferro committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    2e9ceb5 View commit details
    Browse the repository at this point in the history