fix(utils): Locale-aware long formatting (#1512)

donmccurdy · Sep 30, 2024 · aad01c3 · aad01c3
1 parent 84e77f5
commit aad01c3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/benchmarks/utils.ts b/benchmarks/utils.ts
@@ -48,8 +48,9 @@ export function formatTime(ms: number): string {
 	return `${formatLong(ms)} ms`;
 }
 
+const _longFormatter = new Intl.NumberFormat(undefined, { maximumFractionDigits: 0 });
 export function formatLong(x: number): string {
-	return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
+	return _longFormatter.format(x);
 }
 
 export function underline(str: string): string {

diff --git a/packages/cli/src/util.ts b/packages/cli/src/util.ts
@@ -67,8 +67,9 @@ export async function _waitExit(process: ChildProcess): Promise<[unknown, string
 
 // Formatting.
 
+const _longFormatter = new Intl.NumberFormat(undefined, { maximumFractionDigits: 0 });
 export function formatLong(x: number): string {
-	return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
+	return _longFormatter.format(x);
 }
 
 export function formatBytes(bytes: number, decimals = 2): string {

diff --git a/packages/functions/src/utils.ts b/packages/functions/src/utils.ts
@@ -142,9 +142,11 @@ export function formatBytes(bytes: number, decimals = 2): string {
 	return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
 }
 
+const _longFormatter = new Intl.NumberFormat(undefined, { maximumFractionDigits: 0 });
+
 /** @hidden */
 export function formatLong(x: number): string {
-	return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
+	return _longFormatter.format(x);
 }
 
 /** @hidden */