Merge pull request #82 from donghquinn/dev

Dev

src/dto/response.dto.ts

@@ -1,8 +1,5 @@
-import { AuthError } from '@errors/auth.error';
 import { ClientError } from '@errors/client.error';
-import { GeekError } from '@errors/geek.error';
-import { HackerError } from '@errors/hacker.error';
-import { MachineLearningError } from '@errors/machine.error';
+import { GeekError, HackerError, MachineLearningError } from '@errors/news.error';
 import { PrismaError } from '@errors/prisma.error';
 import { ValidatorError } from '@errors/validator.error';
 
@@ -36,10 +33,7 @@ export class SetErrorResponse implements ResponseObject {
   constructor(error: unknown) {
     const errorArray = [];
 
-    if (error instanceof AuthError) {
-      this.resCode = '401';
-      errorArray.push(error.type, error.message);
-    } else if (error instanceof ClientError) {
+    if (error instanceof ClientError) {
       this.resCode = '402';
       errorArray.push(error.type, error.message);
     } else if (error instanceof HackerError) {

src/errors/news.error.ts

@@ -0,0 +1,41 @@
+export class GeekError extends Error {
+  type: string;
+
+  constructor(type: string, message: string, cause?: Error) {
+    super(message);
+
+    this.type = type;
+
+    this.name = '[Geek Error]';
+
+    this.cause = cause;
+  }
+}
+
+export class HackerError extends Error {
+  type: string;
+
+  constructor(type: string, message: string, cause?: Error) {
+    super(message);
+
+    this.type = type;
+
+    this.name = '[Hacker News Error]';
+
+    this.cause = cause;
+  }
+}
+
+export class MachineLearningError extends Error {
+  type: string;
+
+  constructor(type: string, message: string, cause?: Error) {
+    super(message);
+
+    this.type = type;
+
+    this.name = '[Machine Learning Error]';
+
+    this.cause = cause;
+  }
+}

src/middlewares/header.middleware.ts

@@ -14,7 +14,5 @@ export const globalMiddleware = (request: Request, res: Response, next: NextFunc
     Logger.debug('Auth Key Detected');
 
     next();
-  } else {
-    throw new HttpException('Authorize Key Not Match', HttpStatus.BAD_REQUEST);
-  }
+  } else throw new HttpException('Authorize Key Not Match', HttpStatus.BAD_REQUEST);
 };

src/providers/account-manager.pvd.ts

@@ -46,7 +46,7 @@ export class AccountManager {
    * REDIS 에 등록된 회원 정보(로그인 상태 정보) 삭제
    * @param encodedEmail 암호화된 유저 이메일(REDIS 키)
    */
-  public async deleteItem(encodedEmail: string) {
+  public async deleteItem(encodedEmail: string): Promise<boolean> {
     try {
       const index = this.keyList.findIndex((item) => item === encodedEmail);
 
@@ -56,7 +56,11 @@ export class AccountManager {
         await this.redis.del(encodedEmail);
         await this.redis.disconnect();
         ManagerLogger.info('[DELETE] Deleted User Info from Key List and Cache Data');
+
+        return true;
       }
+
+      return false;
     } catch (error) {
       ManagerLogger.error('[DELETE] Delete User Item Error: %o', {
         error,
@@ -134,15 +138,15 @@ export class AccountManager {
         userKey: this.keyList,
       });
 
-      if (key === undefined) return null;
+      if (key === undefined) return false;
 
       ManagerLogger.info('[GET] Found key from keyList');
 
       await this.redis.connect();
       const gotItem = await this.redis.get(key);
       await this.redis.disconnect();
 
-      if (gotItem === null) return null;
+      if (gotItem === null) return false;
 
       const returnData = JSON.parse(gotItem) as ClientLoginItem;