Prevent leak caused by saving promise with can-dom-data-state #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a leak caused by storing a promise with can-dom-data-state. Since this instance of can-dom-data-state comes from Node's module system and not Steal's, this doesn't get cleaned up when we clean up memory with can-dom-mutate. In this case we can replace the usage with Symbols. This commit also turns back on the memory leak test, which is now passing. Closes #560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a leak caused by storing a promise with
can-dom-data-state. Since this instance of can-dom-data-state comes from
Node's module system and not Steal's, this doesn't get cleaned up when
we clean up memory with can-dom-mutate.
In this case we can replace the usage with Symbols.
This commit also turns back on the memory leak test, which is now
passing. Closes #560