Upgrade Steal to 1.x #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, we need to figure out the test situation don't we. I know they are passing locally. |
|
Yea testing this has been quite awkward |
Bajix
commented
Dec 15, 2016
| @@ -158,7 +158,7 @@ define(<%= imports %>, function(<%= args %>){ | |||
| <%= ases %> | |||
| }; | |||
| var isNW = (function(){ | |||
| try{var nr = System._nodeRequire; return nr && nr('nw.gui') !== 'undefined';}catch(e){return false;} | |||
| try{var nr = steal._nodeRequire; return nr && nr('nw.gui') !== 'undefined';}catch(e){return false;} | |||
There was a problem hiding this comment.
@matthewp wasn't sure if this change was required for a Steal upgrade. Is this change potentially problematic?
There was a problem hiding this comment.
Yeah this shouldn't be changed. That's still System.
|
I can't make these tests fail locally |
|
I can probably take a look tomorrow. |
|
Taking a look at this now. |
|
Closing in favor of #36, which should pass soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.