Merge pull request #349 from dolthub/zachmu/timestamp

Fixed timestamp bindvar formatting to match MySQL string expectation
dolthub · May 29, 2024 · 05c840d · 05c840d
2 parents 4c419c3 + e1ffffa
commit 05c840d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/go/sqltypes/bind_variables.go b/go/sqltypes/bind_variables.go
@@ -130,7 +130,7 @@ func BuildBindVariable(v interface{}) (*querypb.BindVariable, error) {
 	case time.Time:
 		return &querypb.BindVariable{
 			Type:   querypb.Type_TIMESTAMP,
-			Value: []byte(v.String()),
+			Value: []byte(v.Format("2006-01-02 15:04:05.000000")),
 		}, nil
 	// TODO: somehow support types.Timespan
 	case nil:

diff --git a/go/sqltypes/bind_variables_test.go b/go/sqltypes/bind_variables_test.go
@@ -154,7 +154,7 @@ func TestBuildBindVariable(t *testing.T) {
 			in: time.Time{},
 			out: &querypb.BindVariable{
 				Type:  querypb.Type_TIMESTAMP,
-				Value: []byte("0001-01-01 00:00:00 +0000 UTC"),
+				Value: []byte("0001-01-01 00:00:00.000000"),
 			},
 		},
 		{