Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parser interface documentation #2716

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update Parser interface documentation #2716

merged 1 commit into from
Oct 24, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Oct 24, 2024

Updates documentation for the Parser interface to document the requirement that implementations must return vitess.ErrEmpty for empty queries. Without this, GMS will not handle empty queries correctly.

Related to: dolthub/doltgresql#884

Copy link
Contributor

@jennifersp jennifersp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this update, super helpful!

@fulghum fulghum merged commit 824fa1d into main Oct 24, 2024
8 checks passed
@fulghum fulghum deleted the fulghum/ping branch October 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants