use datetime precision in information_schema.columns.datetime_precision #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining if a schema change occurred, one of the tables Prisma looks at is the
information_schema.columns.Here, we incorrectly mark all
datetimeandtimestampcolumns as with a precision of 6.If a table has type
DATETIME(3), Prisma would think there was a schema change, and perform a migration when one isn't needed.This PR addresses this issue by having the
information_schema.columnstable accurately reflect the datetime preicision of the columns,fixes: dolthub/dolt#8173