Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix output type for DateAdd() and DateSub() functions #2609

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jul 30, 2024

The output of DateAdd(), AddDate(), DateSub(), and SubDate(), changes if the input is a properly formatted string vs a date/datetime/time/timestamp.

fixes: dolthub/dolt#7304

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@jycor jycor merged commit 6ad97cc into main Jul 31, 2024
8 checks passed
@jycor jycor deleted the james/date branch July 31, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date functions should omit 00:00:00 time component when dealing with string arguments
2 participants