[no-release-notes] Expose JSON type and comparison functions for use by Dolt #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/json-cmp
branch
from
a4d37d7
to
cbea690
Compare
nicktobey
force-pushed
the
nicktobey/json-cmp
branch
from
cbea690
to
1de53bb
Compare
fulghum
approved these changes
Aug 9, 2024
| } | ||
| val, inRange, err := types.JSON.Convert(val) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Does this file need to end in _test.go for it to be only included in the test closure? Or... will this end up pulling in test dependencies, like require into the main dolt executable? I think I remember you saying the partitioning was on a package level, so this package wouldn't be pulled in if it's only used by tests, but wanted to double check.
There was a problem hiding this comment.
We actually need this to not be included in test closure, or else we won't be able to import it in Dolt tests.
The package level partitioning is why this is pulled into its own package: since only the test closure depends on this package, it won't get pulled into the main dolt executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the GMS side of optimized three-way JSON merge. It has the following changes:
JSON_TYPE()function.