Skip to content

Commit

Permalink
fix enginetest
Browse files Browse the repository at this point in the history
  • Loading branch information
James Cor committed Sep 23, 2024
1 parent dabce47 commit 5b1d37c
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 8 deletions.
20 changes: 15 additions & 5 deletions enginetest/enginetests.go
Original file line number Diff line number Diff line change
Expand Up @@ -5636,6 +5636,16 @@ func TestTypesOverWire(t *testing.T, harness ClientHarness, sessionBuilder serve
require.NoError(t, err)
expectedRowSet := script.Results[queryIdx]
expectedRowIdx := 0
var projections []sql.Expression
if trackedIter, ok := engineIter.(*plan.TrackedRowIter); ok {
if commitNode, ok := trackedIter.Node.(*plan.TransactionCommittingNode); ok {
if proj, ok := commitNode.Child().(*plan.Project); ok {
if proj.Deferred {
projections = proj.Projections
}
}
}
}
var engineRow sql.Row
for engineRow, err = engineIter.Next(ctx); err == nil; engineRow, err = engineIter.Next(ctx) {
if !assert.True(t, r.Next()) {
Expand All @@ -5653,11 +5663,11 @@ func TestTypesOverWire(t *testing.T, harness ClientHarness, sessionBuilder serve
break
}
expectedEngineRow := make([]*string, len(engineRow))
for i := range engineRow {
sqlVal, err := sch[i].Type.SQL(ctx, nil, engineRow[i])
if !assert.NoError(t, err) {
break
}
row, err := server.RowToSQL(ctx, sch, engineRow, projections)
if !assert.NoError(t, err) {
break
}
for i, sqlVal := range row {
if !sqlVal.IsNull() {
str := sqlVal.ToString()
expectedEngineRow[i] = &str
Expand Down
1 change: 1 addition & 0 deletions enginetest/server_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ func NewServerQueryEngine(t *testing.T, engine *sqle.Engine, builder server.Sess
_ = s.Start()
}()

engine.Analyzer.ServerMode = true
return &ServerQueryEngine{
t: t,
engine: engine,
Expand Down
6 changes: 3 additions & 3 deletions server/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ func resultForMax1RowIter(ctx *sql.Context, schema sql.Schema, iter sql.RowIter,
return nil, err
}

outputRow, err := rowToSQL(ctx, schema, row, nil)
outputRow, err := RowToSQL(ctx, schema, row, nil)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -650,7 +650,7 @@ func (h *Handler) resultForDefaultIter(
continue
}

outputRow, err := rowToSQL(ctx, schema, row, projections)
outputRow, err := RowToSQL(ctx, schema, row, projections)
if err != nil {
return err
}
Expand Down Expand Up @@ -912,7 +912,7 @@ func updateMaxUsedConnectionsStatusVariable() {
}()
}

func rowToSQL(ctx *sql.Context, s sql.Schema, row sql.Row, projections []sql.Expression) ([]sqltypes.Value, error) {
func RowToSQL(ctx *sql.Context, s sql.Schema, row sql.Row, projections []sql.Expression) ([]sqltypes.Value, error) {
o := make([]sqltypes.Value, max(len(row), len(projections))) // TODO: maybe should be length of schema?
// need to make sure the schema is not null as some plan schema is defined as null (e.g. IfElseBlock)
if len(s) == 0 {
Expand Down

0 comments on commit 5b1d37c

Please sign in to comment.