Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-bump] [no-release-notes] dependency by jycor #967

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

coffeegoddd
Copy link
Contributor

β˜• An Automated Dependency Version Bump PR πŸ‘‘

Initial Changes

The changes contained in this PR were produced by `go get`ing the dependency.

```bash
go get github.com/dolthub/[dependency]/go@[commit]
```

Copy link
Contributor

Main PR
Total 42090 42090
Successful 14428 14426
Failures 27662 27664
Partial Successes1 4690 4690
Main PR
Successful 34.2789% 34.2742%
Failures 65.7211% 65.7258%

${\color{red}Regressions}$

opr_sanity

QUERY:          SELECT a.aggfnoid, p.proname
FROM pg_aggregate as a, pg_proc as p
WHERE a.aggcombinefn = p.oid AND
    a.aggtranstype = 'internal'::regtype AND p.proisstrict;
RECEIVED ERROR: type "internal" does not exist (errno 1105) (sqlstate HY000)
QUERY:          SELECT aggfnoid, aggtranstype, aggserialfn, aggdeserialfn
FROM pg_aggregate
WHERE (aggserialfn != 0 OR aggdeserialfn != 0)
  AND (aggtranstype != 'internal'::regtype OR aggcombinefn = 0 OR
       aggserialfn = 0 OR aggdeserialfn = 0);
RECEIVED ERROR: type "internal" does not exist (errno 1105) (sqlstate HY000)

type_sanity

QUERY:          SELECT t1.oid, t1.typname as basetype, t2.typname as arraytype,
       t2.typsubscript
FROM   pg_type t1 LEFT JOIN pg_type t2 ON (t1.typarray = t2.oid)
WHERE  t1.typarray <> 0 AND
       (t2.oid IS NULL OR
        t2.typsubscript <> 'array_subscript_handler'::regproc);
RECEIVED ERROR: "function "array_subscript_handler" does not exist" (errno 1105) (sqlstate HY000)
QUERY:          SELECT t1.oid, t1.typname, p1.oid, p1.proname
FROM pg_type AS t1, pg_proc AS p1
WHERE t1.typoutput = p1.oid AND NOT
    (p1.prorettype = 'cstring'::regtype AND NOT p1.proretset);
RECEIVED ERROR: type "cstring" does not exist (errno 1105) (sqlstate HY000)

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

Copy link
Contributor

@jennifersp jennifersp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regressed tests are actually not regression as they are from a dropped error fix in GMS.

@jycor jycor merged commit 6bba3e2 into main Nov 15, 2024
13 checks passed
@jycor jycor deleted the jycor-0995efed branch November 15, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants