Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dolt_schema and dolt_procedure tests #964

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Add dolt_schema and dolt_procedure tests #964

merged 5 commits into from
Nov 15, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 14426 14426
Failures 27664 27664
Partial Successes1 4690 4690
Main PR
Successful 34.2742% 34.2742%
Failures 65.7258% 65.7258%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@tbantle22 tbantle22 force-pushed the taylor/schema-tests-2 branch from 5bd3afc to ff5ba9e Compare November 15, 2024 00:49
@tbantle22 tbantle22 marked this pull request as ready for review November 15, 2024 00:50
@tbantle22 tbantle22 force-pushed the taylor/schema-tests-2 branch from 20c34a1 to 2998b02 Compare November 15, 2024 19:12
zachmu
zachmu approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no notes

@tbantle22 tbantle22 merged commit 563f221 into main Nov 15, 2024
13 checks passed
@tbantle22 tbantle22 deleted the taylor/schema-tests-2 branch November 15, 2024 23:15
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @zachmu