Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepared statement support #87

Merged
merged 34 commits into from
Jan 10, 2024
Merged

Prepared statement support #87

merged 34 commits into from
Jan 10, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 5, 2024 •
edited
Loading

This PR implements postgres prepared statements with support for $1 style parameters in query strings. If this approach is reasonable, the next step would be to add support for additional types and lots more tests.

Also missing is support for the client manually specifying the types of parameters in a Parse message, which is required for certain statements where the type information cannot be determined based on referenced columns.

Companion PRs:

dolthub/go-mysql-server#2239
dolthub/vitess#299

zachmu added 23 commits December 19, 2023 14:47
@zachmu
Added comPrepare
19fbeb5
@zachmu
Define PortalData
0688042
@zachmu
Another caching change
1c779bf
@zachmu
Checkpoint
648cadf
@zachmu
Close to first draft
e43c495
@zachmu
Prepared statement tests
a52a092
@zachmu
Convert placeholder nodes
b1ba5ab
@zachmu
Adding object ids to prepare responses
15d81a8
@zachmu
Some fake scaffolding to make more inroads before fixing interfaces
37be300
@zachmu
Bug fixes for bind varsD
e93d747
@zachmu
Merge branch 'main' into zachmu/prepared
0a313b2
@zachmu
refactoring: split out query / execute
46fb598
@zachmu
Getting closer
f7623c0
@zachmu
Destroy the unnamed statement on query
a1782fd
@zachmu
mising err handling
70f5701
@zachmu
Cleanup, added support for the Close message
8b24280
@zachmu
More prepared statement tests
f88dcb3
@zachmu
Moar tests
fa8c9b2
@zachmu
Moar tests
cf63ea0
@zachmu
Int64 support
ce35cbd
@zachmu
Added skipped tests for varchar columns with no length
c88bdad
@zachmu
Better tests
b684aa1
@zachmu
Merge main
9492d9c
@zachmu zachmu mentioned this pull request Jan 5, 2024
Merged
@zachmu zachmu requested a review from Hydrocharged January 5, 2024 02:02
Hydrocharged
Hydrocharged approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Really glad you're tackling this. Small nitpick comments, but the core logic looks good to me! Not straightforward, however I think that's just the nature of the beast.

postgres/messages/row_description.go Outdated Show resolved Hide resolved
server/ast/expr.go Show resolved Hide resolved
server/listener.go Outdated Show resolved Hide resolved
testing/go/framework.go Outdated Show resolved Hide resolved
testing/go/prepared_statement_test.go Outdated Show resolved Hide resolved
@zachmu zachmu marked this pull request as ready for review January 10, 2024 23:33
@zachmu zachmu merged commit 5e70284 into main Jan 10, 2024
7 checks passed
@zachmu zachmu deleted the zachmu/prepared branch January 10, 2024 23:57
@BrewTestBot BrewTestBot mentioned this pull request Jan 11, 2024
Merged
@Porkepix Porkepix mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged