Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue test #73

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Correct issue test #73

merged 1 commit into from
Dec 13, 2023

Conversation

Hydrocharged
Copy link
Collaborator

#25 was incorrect in its assumptions, but still proved valuable for learning. As a result, I've modified the skipped test so that we're now checking the same relative thing.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to remove that t.Skip! 🙌

@Hydrocharged Hydrocharged merged commit 837866e into main Dec 13, 2023
6 checks passed
@Hydrocharged Hydrocharged deleted the daylon/fix-column branch December 13, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants