Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented support for various expressions needed by sqllogictest #60

Merged
merged 15 commits into from
Dec 1, 2023
Merged

Implemented support for various expressions needed by sqllogictest #60

merged 15 commits into from
Dec 1, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Nov 30, 2023

No description provided.

@zachmu zachmu requested a review from Hydrocharged December 1, 2023 01:56
Hydrocharged
Hydrocharged approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely have questions regarding CROSS JOIN, but you're probably more knowledgeable than me regarding joins, so I'll approve it assuming you'll do the correct thing.

server/ast/table_expr.go Show resolved Hide resolved
testing/go/regression_test.go Outdated Show resolved Hide resolved
server/ast/func_expr.go Show resolved Hide resolved
@zachmu
Copy link
Member Author

zachmu commented Dec 1, 2023

I actually commented out the nullif / coalesce tests, because they require updating Dolt and that is relatively involved (we need to make changes to how we run the server)

@zachmu zachmu merged commit 39f8360 into main Dec 1, 2023
6 checks passed
@zachmu zachmu deleted the zachmu/exprs branch December 1, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged