-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better type handling in harness, support COUNT(*) expressions and CAST #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I say it in the comments but I'll mention it here again: I don't want to come across as being pedantic with the requests. I just want the codebase to remain consistent and as high-quality as possible for as long as we can, before we inevitably have to start working fast and hacking things to meet customer demand. The better the foundation, the easier we'll have it later on.
Preferably, all of this would be rules in some static analyzer, but I have no clue how to set that up, so it's PR comments for now. I probably should write some analyzer or linter or something, as this will break down once I'm no longer the only reviewer.
I think all this is taken care of but github is still blocking merge, not sure why. Want to stamp? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
No description provided.