Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null literal handling #56

Merged
merged 10 commits into from
Nov 27, 2023
Merged

Null literal handling #56

merged 10 commits into from
Nov 27, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Nov 22, 2023

Also adds unit tests for error handling during extended query execution, and some debug logging for messages received.

@zachmu zachmu requested a review from Hydrocharged November 22, 2023 23:50
Hydrocharged
Hydrocharged approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few small comments

server/ast/expr.go Outdated Show resolved Hide resolved
server/listener.go Outdated Show resolved Hide resolved
testing/logictest/harness/doltgres_harness.go Outdated Show resolved Hide resolved
testing/go/prepared_statement_test.go Outdated Show resolved Hide resolved
testing/go/prepared_statement_test.go Show resolved Hide resolved
@zachmu zachmu merged commit e0f8ccf into main Nov 27, 2023
6 checks passed
@zachmu zachmu deleted the zachmu/decoder branch November 27, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged