Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on non-ascending index #51

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Warn on non-ascending index #51

merged 1 commit into from
Nov 16, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Nov 15, 2023

This is to bootstrap compatibility until we can implement descending order indexes. Since GMS assumes all indexes are ordered ascending, this will not impact correctness, just produce slightly different schemas.

@zachmu zachmu requested a review from Hydrocharged November 15, 2023 22:49
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu merged commit cd4fb7b into main Nov 16, 2023
5 checks passed
@zachmu zachmu deleted the zachmu/sqllogictest branch November 16, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants