Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed initialization, expanded build script, username as database #30

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Hydrocharged
Copy link
Collaborator

@Hydrocharged Hydrocharged commented Nov 1, 2023

Fixes #27
Moves the tests to individual files (which will eventually be filled as more tests are added in the future), as the single file was growing in size. Want to avoid the GMS situation where we have a massive file with most tests.

Also makes changes as discussed in the internal channel. This includes changes to how initialization is handled, in that we create a doltgres subdirectory and initialize inside of that. In addition, we cannot run the server from within an initialized directory. Lastly, we use the user's name as the database if one is not specified. For more details, refer to the internal channel.

@Hydrocharged Hydrocharged requested a review from zachmu November 1, 2023 11:11
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/server.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 351e881 into main Nov 1, 2023
5 checks passed
@Hydrocharged Hydrocharged deleted the daylon/fixes branch November 1, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants