Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UUID type #125

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Added UUID type #125

merged 1 commit into from
Feb 14, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This adds the UUID type. Ignore the serialization portion for now, I'll figure out a different serialization scheme later that should work for all types (including user-defined types). While this works, we need to forward the type information through to the connector so it can use the correct OID. For now though, this should be enough to unblock.

@Hydrocharged Hydrocharged requested a review from zachmu February 13, 2024 14:21
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only real comment is why we are using the parser intermediate object instead of the golang uuid library

postgres/parser/uuid/codec.go Show resolved Hide resolved
server/types/uuid.go Show resolved Hide resolved
server/types/uuid.go Show resolved Hide resolved
server/types/uuid.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit edfe86e into main Feb 14, 2024
7 checks passed
@Hydrocharged Hydrocharged deleted the daylon/uuid branch February 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants