Skip to content

Commit

Permalink
Merge branch 'main' into james/exists
Browse files Browse the repository at this point in the history
  • Loading branch information
James Cor committed Nov 18, 2024
2 parents 724d1ae + 36e63f6 commit 8b446ea
Showing 1 changed file with 40 additions and 26 deletions.
66 changes: 40 additions & 26 deletions testing/go/regression/tool/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ func main() {
if len(trackersFrom) == len(trackersTo) {
// Handle regressions (which we'll display first)
foundAnyFailDiff := false
countRegression := 0
for trackerIdx := range trackersFrom {
// They're sorted, so this should always hold true.
// This will really only fail if the tests were updated.
Expand All @@ -105,30 +106,37 @@ func main() {
}
for _, trackerToItem := range trackersTo[trackerIdx].FailPartialItems {
if _, ok := fromFailItems[trackerToItem.Query]; !ok {
if !foundAnyFailDiff {
foundAnyFailDiff = true
sb.WriteString("\n## ${\\color{red}Regressions}$\n")
if countRegression <= 50 {
if !foundAnyFailDiff {
foundAnyFailDiff = true
sb.WriteString("\n## ${\\color{red}Regressions}$\n")
}
if !foundFileDiff {
foundFileDiff = true
sb.WriteString(fmt.Sprintf("### %s\n", trackersFrom[trackerIdx].File))
}
sb.WriteString(fmt.Sprintf("```\nQUERY: %s\n", trackerToItem.Query))
if len(trackerToItem.ExpectedError) != 0 {
sb.WriteString(fmt.Sprintf("EXPECTED ERROR: %s\n", trackerToItem.ExpectedError))
}
if len(trackerToItem.UnexpectedError) != 0 {
sb.WriteString(fmt.Sprintf("RECEIVED ERROR: %s\n", trackerToItem.UnexpectedError))
}
for _, partial := range trackerToItem.PartialSuccess {
sb.WriteString(fmt.Sprintf("PARTIAL: %s\n", partial))
}
sb.WriteString("```\n")
}
if !foundFileDiff {
foundFileDiff = true
sb.WriteString(fmt.Sprintf("### %s\n", trackersFrom[trackerIdx].File))
}
sb.WriteString(fmt.Sprintf("```\nQUERY: %s\n", trackerToItem.Query))
if len(trackerToItem.ExpectedError) != 0 {
sb.WriteString(fmt.Sprintf("EXPECTED ERROR: %s\n", trackerToItem.ExpectedError))
}
if len(trackerToItem.UnexpectedError) != 0 {
sb.WriteString(fmt.Sprintf("RECEIVED ERROR: %s\n", trackerToItem.UnexpectedError))
}
for _, partial := range trackerToItem.PartialSuccess {
sb.WriteString(fmt.Sprintf("PARTIAL: %s\n", partial))
}
sb.WriteString("```\n")
countRegression += 1
}
}
}
if countRegression > 0 {
sb.WriteString(fmt.Sprintf("\n## ${\\color{red}Total Regressions: %v}$\n", countRegression))
}
// Handle progressions (which we'll display second)
foundAnySuccessDiff := false
countProgression := 0
for trackerIdx := range trackersFrom {
// They're sorted, so this should always hold true.
// This will really only fail if the tests were updated.
Expand All @@ -142,18 +150,24 @@ func main() {
}
for _, trackerToItem := range trackersTo[trackerIdx].SuccessItems {
if _, ok := fromSuccessItems[trackerToItem.Query]; !ok {
if !foundAnySuccessDiff {
foundAnySuccessDiff = true
sb.WriteString("\n## ${\\color{lightgreen}Progressions}$\n")
}
if !foundFileDiff {
foundFileDiff = true
sb.WriteString(fmt.Sprintf("### %s\n", trackersFrom[trackerIdx].File))
if countProgression <= 50 {
if !foundAnySuccessDiff {
foundAnySuccessDiff = true
sb.WriteString("\n## ${\\color{lightgreen}Progressions}$\n")
}
if !foundFileDiff {
foundFileDiff = true
sb.WriteString(fmt.Sprintf("### %s\n", trackersFrom[trackerIdx].File))
}
sb.WriteString(fmt.Sprintf("```\nQUERY: %s\n```\n", trackerToItem.Query))
}
sb.WriteString(fmt.Sprintf("```\nQUERY: %s\n```\n", trackerToItem.Query))
countProgression += 1
}
}
}
if countProgression > 0 {
sb.WriteString(fmt.Sprintf("\n## ${\\color{lightgreen}Total Progressions: %v}$\n", countProgression))
}
}
sb.WriteString("[^1]: These are tests that we're marking as `Successful`, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.")
fmt.Println(sb.String())
Expand Down

0 comments on commit 8b446ea

Please sign in to comment.