Merge pull request #763 from dolthub/fulghum/column-default-exprs

Wrap column default expressions in `ParenExpr`to match MySQL's requirements

server/ast/column_table_def.go

@@ -65,6 +65,10 @@ func nodeColumnTableDef(node *tree.ColumnTableDef) (_ *vitess.ColumnDefinition,
 	if err != nil {
 		return nil, err
 	}
+	// Wrap any default expression using a function call in parens to match MySQL's column default requirements
+	if _, ok := defaultExpr.(*vitess.FuncExpr); ok {
+		defaultExpr = &vitess.ParenExpr{Expr: defaultExpr}
+	}
 	if len(node.CheckExprs) > 0 {
 		return nil, fmt.Errorf("column-declared CHECK expressions are not yet supported")
 	}

testing/go/create_table_test.go

@@ -45,5 +45,23 @@ func TestCreateTable(t *testing.T) {
 				},
 			},
 		},
+		{
+			Name: "Create table with column default expression using function",
+			Assertions: []ScriptTestAssertion{
+				{
+					// Test with a function in the column default expression
+					Query:    "create table t1 (pk int primary key, c1 TEXT default length('Hello World!'));",
+					Expected: []sql.Row{},
+				},
+				{
+					Query:    "insert into t1(pk) values (1);",
+					Expected: []sql.Row{},
+				},
+				{
+					Query:    "select * from t1;",
+					Expected: []sql.Row{{1, "12"}},
+				},
+			},
+		},
 	})
 }