Skip to content

Commit

Permalink
Merge pull request #922 from dolthub/daylon/regression-progression-se…
Browse files Browse the repository at this point in the history
…paration

[no-release-notes] Fixed Regressions and Progressions mixing
  • Loading branch information
Hydrocharged authored Nov 5, 2024
2 parents 74e5d90 + 66b378d commit 4321d02
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions testing/go/regression/tool/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,14 @@ func main() {
(float64(fromFail)/float64(fromTotal))*100.0,
(float64(toFail)/float64(toTotal))*100.0))
if len(trackersFrom) == len(trackersTo) {
// Handle regressions (which we'll display first)
foundAnyFailDiff := false
foundAnySuccessDiff := false
for trackerIdx := range trackersFrom {
// They're sorted, so this should always hold true.
// This will really only fail if the tests were updated.
if trackersFrom[trackerIdx].File != trackersTo[trackerIdx].File {
continue
}
// Handle regressions (which we'll display first)
foundFileDiff := false
fromFailItems := make(map[string]struct{})
for _, trackerFromItem := range trackersFrom[trackerIdx].FailPartialItems {
Expand Down Expand Up @@ -127,8 +126,16 @@ func main() {
sb.WriteString("```\n")
}
}
// Handle progressions (which we'll display second)
foundFileDiff = false
}
// Handle progressions (which we'll display second)
foundAnySuccessDiff := false
for trackerIdx := range trackersFrom {
// They're sorted, so this should always hold true.
// This will really only fail if the tests were updated.
if trackersFrom[trackerIdx].File != trackersTo[trackerIdx].File {
continue
}
foundFileDiff := false
fromSuccessItems := make(map[string]struct{})
for _, trackerFromItem := range trackersFrom[trackerIdx].SuccessItems {
fromSuccessItems[trackerFromItem.Query] = struct{}{}
Expand Down

0 comments on commit 4321d02

Please sign in to comment.