Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log server metrics heartbeat #8450

Merged
merged 2 commits into from
Oct 14, 2024
Merged

log server metrics heartbeat #8450

merged 2 commits into from
Oct 14, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 14, 2024 •
edited
Loading

fixes: #8443

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e4b2cb8 ok 5937457
version total_tests
e4b2cb8 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit 66b03de into main Oct 14, 2024
21 of 22 checks passed
@jycor jycor deleted the james/log branch October 14, 2024 22:49
@BrewTestBot BrewTestBot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log metrics calls to eventsapi.dolthub.com in the Dolt server logs at appropriate log levels
3 participants
@jycor @coffeegoddd @zachmu