Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] add warning test for dotnet integration #8445

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[no-release-notes] add warning test for dotnet integration #8445

merged 3 commits into from
Oct 11, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 11, 2024

tests for: #8440

zachmu
zachmu approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
96977ff ok 5937457
version total_tests
96977ff 5937457
correctness_percentage
100.0

@jycor jycor merged commit 1ba71c3 into main Oct 11, 2024
21 of 22 checks passed
@jycor jycor deleted the james/dotnet branch October 11, 2024 22:44
@jycor jycor mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycor @coffeegoddd @zachmu