Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return information_schema schema for doltgres #8391

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Return information_schema schema for doltgres #8391

merged 6 commits into from
Sep 26, 2024

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 mentioned this pull request Sep 25, 2024
Merged
@tbantle22 tbantle22 marked this pull request as ready for review September 26, 2024 16:58
zachmu
zachmu approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/libraries/doltcore/sqle/database.go Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
76db2ba ok 5937457
version total_tests
76db2ba 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 merged commit e175b89 into main Sep 26, 2024
20 of 22 checks passed
@tbantle22 tbantle22 deleted the taylor/info-schema branch September 26, 2024 17:59
This was referenced Sep 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbantle22 @coffeegoddd @zachmu @nicktobey