Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] /go/{libraries,store}: revert removal of GetTopNTopoOrderedCommitsMatching, fix CSMetricWrapper chunkstore #7509

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[no-release-notes] /go/{libraries,store}: revert removal of GetTopNTopoOrderedCommitsMatching, fix CSMetricWrapper chunkstore #7509

merged 1 commit into from
Feb 16, 2024

Conversation

coffeegoddd
Copy link
Contributor

No description provided.

reltuk
reltuk approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
99.999562 to 99.999562
version result total
1749688 not ok 26
1749688 ok 5937431
version total_tests
1749688 5937457
correctness_percentage
99.999562

@coffeegoddd coffeegoddd merged commit 1177f88 into main Feb 16, 2024
33 of 34 checks passed
@coffeegoddd coffeegoddd deleted the db/fix-stuff branch February 16, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coffeegoddd @reltuk