Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validation for dropping an auto_increment primary key column #7462

Merged
merged 11 commits into from
Feb 7, 2024
Merged

Update validation for dropping an auto_increment primary key column #7462

merged 11 commits into from
Feb 7, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Feb 6, 2024

Allows auto_increment primary key columns to be dropped, so long as there exists a secondary index that covers the auto_increment column.

Depends on dolthub/go-mysql-server#2316

Related to #7456

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999124
version result total
fd4b048 not ok 52
fd4b048 ok 5937405
version total_tests
fd4b048 5937457
correctness_percentage
99.999124

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999124
version result total
0f95427 not ok 52
0f95427 ok 5937405
version total_tests
0f95427 5937457
correctness_percentage
99.999124

@fulghum fulghum requested a review from zachmu February 6, 2024 21:00
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999562
version result total
6517e97 not ok 26
6517e97 ok 5937431
version total_tests
6517e97 5937457
correctness_percentage
99.999562

zachmu
zachmu approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
99.999562 to 99.999562
version result total
41604c3 not ok 26
41604c3 ok 5937431
version total_tests
41604c3 5937457
correctness_percentage
99.999562

@fulghum fulghum merged commit 0428499 into main Feb 7, 2024
15 of 16 checks passed
@fulghum fulghum deleted the fulghum/dolt-7456 branch February 7, 2024 00:21
@BrewTestBot BrewTestBot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulghum @coffeegoddd @zachmu