Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for dolt_patch #6367

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Bug fixes for dolt_patch #6367

merged 3 commits into from
Jul 21, 2023

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 20, 2023

Adding support in dolt_patch() to:

  • return data diff patch statements when there are schema changes
  • return schema diff patch statements for charset/collation changes

@fulghum fulghum marked this pull request as ready for review July 21, 2023 17:47
@fulghum fulghum requested a review from jycor July 21, 2023 17:52
jycor
jycor approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 1623798 into main Jul 21, 2023
19 checks passed
@Hydrocharged Hydrocharged deleted the fulghum/dolt_patch branch August 24, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulghum @jycor