Skip to content

Commit

Permalink
Merge pull request #8484 from dolthub/db/bump-doltgres
Browse files Browse the repository at this point in the history
/go/performance/continuous_integration/SysbenchDockerfile: bump doltgres version tested in sysbench tester
  • Loading branch information
coffeegoddd authored Oct 24, 2024
2 parents 966503a + eb4bc61 commit fe54813
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion go/performance/continuous_integration/SysbenchDockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ RUN git clone https://github.com/dolthub/sysbench-lua-scripts.git
RUN git clone https://github.com/Percona-Lab/sysbench-tpcc.git

# install doltgres
ENV DOLTGRESQL_VERSION=${DOLTGRESQL_VERSION:-v0.7.5}
ENV DOLTGRESQL_VERSION=${DOLTGRESQL_VERSION:-v0.13.0}
RUN git clone https://github.com/dolthub/doltgresql.git
RUN cd doltgresql/utils/doltgres_builder/cmd && go run . "$DOLTGRESQL_VERSION"
ENV PATH="/doltgresql/utils/doltgres_builder/cmd/doltgresBin/$DOLTGRESQL_VERSION:${PATH}"
Expand Down
10 changes: 6 additions & 4 deletions go/performance/utils/benchmark_runner/doltgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,13 @@ func (b *doltgresBenchmarkerImpl) createTestingDb(ctx context.Context) error {
// close database
defer db.Close()

// todo: currently db.Ping is busted in doltgres,
// results in error
// check db
err = db.PingContext(ctx)
if err != nil {
return err
}
//err = db.PingContext(ctx)
//if err != nil {
// return err
//}

_, err = db.ExecContext(ctx, fmt.Sprintf(createDatabaseTemplate, dbName))
return err
Expand Down

0 comments on commit fe54813

Please sign in to comment.