Merge pull request #8378 from dolthub/aaron/remotestorage-ioCopy-leak

go: doltcore/remotestorage: reliable: Fix leaked goroutines when the context is canceled while reading the HTTP response.
dolthub · Sep 24, 2024 · f4c9dc4 · f4c9dc4
2 parents bf8d3e8 + 4a6db7e
commit f4c9dc4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/go/libraries/doltcore/remotestorage/internal/reliable/http.go b/go/libraries/doltcore/remotestorage/internal/reliable/http.go
@@ -221,8 +221,11 @@ func StreamingRangeDownload(ctx context.Context, req StreamingRangeRequest) Stre
 	}()
 
 	return StreamingResponse{
-		Body:   r,
-		cancel: cancel,
+		Body: r,
+		cancel: func() {
+			r.Close()
+			cancel()
+		},
 	}
 }