Only serialize schema comment if it's not empty

dolthub · Jan 31, 2024 · 7894356 · 7894356
1 parent 936fc16
commit 7894356
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/go/libraries/doltcore/schema/encoding/serialization.go b/go/libraries/doltcore/schema/encoding/serialization.go
@@ -56,7 +56,6 @@ func serializeSchemaAsFlatbuffer(sch schema.Schema) ([]byte, error) {
 	rows := serializeClusteredIndex(b, sch)
 	indexes := serializeSecondaryIndexes(b, sch, sch.Indexes().AllIndexes())
 	checks := serializeChecks(b, sch.Checks().AllChecks())
-	comment := b.CreateString(sch.GetComment())
 
 	var hasFeaturesAfterTryAccessors bool
 	for _, col := range sch.GetAllCols().GetColumns() {
@@ -65,17 +64,18 @@ func serializeSchemaAsFlatbuffer(sch schema.Schema) ([]byte, error) {
 			break
 		}
 	}
-	if sch.GetComment() != "" {
-		hasFeaturesAfterTryAccessors = true
-	}
 
 	serial.TableSchemaStart(b)
 	serial.TableSchemaAddClusteredIndex(b, rows)
 	serial.TableSchemaAddColumns(b, columns)
 	serial.TableSchemaAddSecondaryIndexes(b, indexes)
 	serial.TableSchemaAddChecks(b, checks)
 	serial.TableSchemaAddCollation(b, serial.Collation(sch.GetCollation()))
-	serial.TableSchemaAddComment(b, comment)
+	if sch.GetComment() != "" {
+		comment := b.CreateString(sch.GetComment())
+		serial.TableSchemaAddComment(b, comment)
+		hasFeaturesAfterTryAccessors = true
+	}
 	if hasFeaturesAfterTryAccessors {
 		serial.TableSchemaAddHasFeaturesAfterTryAccessors(b, hasFeaturesAfterTryAccessors)
 	}