Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge prisoners before update #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Purge prisoners before update #43

wants to merge 3 commits into from

Conversation

mikeykhalil
Copy link
Contributor

@mikeykhalil mikeykhalil commented May 26, 2020 •
edited
Loading

  • Purge prisoners cache before interacting with Redis in case there is an error obtaining the lock or fetching the prisoners. This way we error on the side of caution.
  • Add go vet and gofmt to ci

@mikeykhalil mikeykhalil force-pushed the purge-prisoners-before-update branch from 1efb348 to 2217fa2 Compare May 26, 2020 05:13
esterlinej
esterlinej approved these changes May 26, 2020
View reviewed changes
Copy link

@esterlinej esterlinej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esterlinej esterlinej esterlinej approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeykhalil @esterlinej