Fix the optmisation problem for firedrake and pyrol. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR leads to an error in dolfin-adjoint. Such an error can be fixed with the PR 25. |
Ig-dolci
commented
Mar 13, 2024
Ig-dolci
commented
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the need for a dual
RolVector. This method uses theOverloadeType._riesz_representationto map theRolVectorfrom the primal to the dual space.A dual
RolVectoris necessary for a case where pyadjoint is incorporated in software using the mathematical concept of primal and dual spaces, such as in Firedrake.In Firedrake the result of
applyAdjointJacobianandapplyAdjointHessianareCofunction. However,RolVectoris inherently primal, which leads to errors related to the wrong usage of primalRolVectorinstead of a dualRolVector.