Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #123 #124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #123 #124

wants to merge 3 commits into from

Conversation

dploeger
Copy link

This is an idea for #123: I've added a "paragraphs=x" parameter. The plugin then skips all other instructions after the maximum paragraph count (identified when finding a "p_open" instruction) and adds the read-more link.

@dploeger
Copy link
Author

You can see it in action here http://dennis.dieploegers.de/doku.php/my2cents/start


for ($a=0; $a<$open_sects; $a++) {

$ins[] = array('section_close', array());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there can't be more than one open section (sections aren't nested) but paragraphs can occur e.g. inside instructions from the wrap plugin. I fear the best we can do is keeping track of all possible instructions we know.

@michitux
Copy link
Member

When only a certain number of paragraphs is included I think this should be the same as including only one section, this is in syntax/include.php, line 143 and affects the behavior of internal/local links.

Apart from that and the possible problem with instructions that aren't closed I think this can be merged. Thank you very much for the pull request!

@dploeger
Copy link
Author

Thanks and you're welcome.

@dploeger
Copy link
Author

dploeger commented Sep 1, 2013

Do you merge it then? :)

@dploeger
Copy link
Author

Hey, @michitux. What about this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants