[Fix] Couldn't connect to Torii on IOS/Android #2726
Conversation
WalkthroughOhayo, sensei! The changes in this pull request focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant Tonic
Client->>Tonic: Initiate gRPC request
Tonic->>Server: Forward request with TLS
Server-->>Tonic: Send response
Tonic-->>Client: Return response
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Cargo.toml (1)
244-244: Ohayo sensei! Consider adding documentation about mobile requirements 📝Since this change specifically addresses mobile platform requirements, it would be valuable to document this dependency in the project's mobile setup guide or README. This will help future developers understand why this feature is necessary for mobile deployments.
Would you like me to help draft the documentation explaining the mobile TLS requirements?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
🔇 Additional comments (1)
Cargo.toml (1)
244-244: Ohayo sensei! The tonic feature addition looks good! ✨
Adding the tls-webpki-roots feature to tonic is a solid solution for fixing the iOS/Android connectivity issues. This feature ensures proper TLS certificate validation on mobile platforms by using the webpki roots for certificate verification.
Let's verify if this change resolves similar issues in other mobile-related code:
✅ Verification successful
Ohayo sensei! The tonic TLS feature addition is verified and good to go! 🌟
The search results show that the TLS/certificate handling in the codebase is primarily focused on WebRTC certificates in the libp2p implementation, which is separate from the gRPC/tonic TLS configuration. The addition of tls-webpki-roots feature to tonic is an independent enhancement that specifically addresses mobile platform connectivity without conflicting with or requiring changes to other parts of the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any mobile-specific TLS or connection handling code
rg -i "ios|android|mobile|tls|certificate" --type rust
Length of output: 1852
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 56.23% 56.24% +0.01%
==========================================
Files 415 415
Lines 53206 53206
==========================================
+ Hits 29922 29928 +6
+ Misses 23284 23278 -6 ☔ View full report in Codecov by Sentry. |
* add tls webpki roots * format: fix white space
I am using dojo.c on Unreal Engine 5 to make an IOS mobile app. I got a transport error issue when trying to connect to Torii.
As I already worked on the connect issue on other platforms that web, I searched for other flags that could help and stubbled upon this:
dashpay/platform#1828
I've added this flag, recompile dojo.c and not it works, my IOS app can connect to Torii 🥳
Summary by CodeRabbit
New Features
tonicdependency.Bug Fixes
Documentation