Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii): integrate long poll getTransactions #1688

Closed
wants to merge 27 commits into from

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Mar 21, 2024

closes DOJ-269
closes #1363

use the toriI_getTransactions long poll api when using katana and fallback to getEvents

@Larkooo Larkooo changed the title feat: start defining provider interface & expose katana types feat: integrate long poll getTransactions into torii Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 21.21923% with 672 lines in your changes are missing coverage. Please review.

Project coverage is 66.98%. Comparing base (af9cdf6) to head (47c8f10).

❗ Current head 47c8f10 differs from pull request most recent head 8c1326f. Consider uploading reports for the commit 8c1326f to get more accurate results

Files Patch % Lines
crates/torii/core/src/provider/mod.rs 13.97% 468 Missing ⚠️
crates/torii/core/src/engine.rs 33.83% 88 Missing ⚠️
crates/katana/rpc/rpc-types/src/transaction.rs 9.09% 70 Missing ⚠️
crates/torii/core/src/provider/provider.rs 2.50% 39 Missing ⚠️
bin/torii/src/main.rs 0.00% 4 Missing ⚠️
crates/torii/core/src/provider/http.rs 94.11% 2 Missing ⚠️
crates/torii/core/src/provider/transport.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   70.29%   66.98%   -3.31%     
==========================================
  Files         315      299      -16     
  Lines       35850    32510    -3340     
==========================================
- Hits        25201    21778    -3423     
- Misses      10649    10732      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added the torii label Mar 25, 2024
@Larkooo Larkooo marked this pull request as ready for review March 26, 2024 17:46
@Larkooo Larkooo marked this pull request as draft May 10, 2024 15:10
@glihm glihm changed the title feat: integrate long poll getTransactions into torii feat(torii): integrate long poll getTransactions Jul 9, 2024
@glihm
Copy link
Collaborator

glihm commented Oct 31, 2024

Will close this for now. We will re-open if necessary. Interesting to keep torii using standard json rpc which is for now well optimized with the recent events.

@glihm glihm closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending txn long poll rpc endpoint
2 participants