refactor(sozo): make event parsing logic modular and reusable

[Matth26]

This PR addresses Issue #882, resolves DOJ-108, focusing on leveraging the cainome parser for ABI parsing and processing Emitted Events.

Current Progress

• Successfully integrated the cainome parser for parsing ABI and Emitted Events.
• CoreBasic and Array data structures are correctly parsed.

@glihm, could I have your review on the work done so far to see if it aligns with your expectations?

[glihm]

Awesome, thanks for the first draft of this! Definitely aligned. 🚀

I left a comment about a function, other than that will take a deeper look after the cleanup and testing.

But running sozo locally to test that, seems all good for now compared to the previous implementation.

Appreciate the emphasis on testing you've started. 👍

[Matth26]

Thanks for the review !

But running sozo locally to test that, seems all good for now compared to the previous implementation.

Yes I've checked on events I had locally to be the same as before, but couldn't test them all (hence the test for the Span)
And I fixed the custom event code which was not working if the event had more than 2 keys (which is the case in my game)

To allow some configuration, I think we should have 2 types or choices (mostly for felts and integers)

Sure, I did it quick and dirty with the is_nested but a proper config would be better

This can be done later, just wanted to point out that it's concerning only cainome logic so, may be better to move it there. 👍

Totally agree, I'll move this in cainome repo 👍

[Matth26]

I haven't added the print_value method to CoreBasic yet, as I wanted to know how to manage the cainome version.
However, the code is otherwise ready for review. I've cleaned up the code and added tests.

[codecov]

Codecov Report

Attention: Patch coverage is 93.05556% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 70.10%. Comparing base (88bae9f) to head (440cbb6).
Report is 1 commits behind head on main.

Files	Patch %	Lines
bin/sozo/src/ops/events.rs	93.05%	30 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
+ Coverage   69.55%   70.10%   +0.55%     
==========================================
  Files         266      266              
  Lines       27217    27536     +319     
==========================================
+ Hits        18931    19305     +374     
+ Misses       8286     8231      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kariy]

Good work on this @Matth26!

Left some comments after briefly went through it.

[Matth26]

Thanks @kariy for the review. I've updated the error handling based on your suggestions, and I think it's better now. Please let me know your thoughts 👍

[glihm]

Thanks for the work here @Matth26!
Some minor comments. I'll probably check how we can integrate the printing of the core token into cainome. Keep you posted.

[glihm]

Thank you for the effort @Matth26 and the time dedicated to that!
Cainome integration can be done later, and it looks great for a first rework on event support with cainome, good job! 🚀

[kariy]

looks good to me... just need to address the one thing and then we're good

[Matth26]

I've just added the error as @kariy suggested

[glihm]

Thanks @Matth26 for the work here!
As seen with @kariy we may enhance how the ABI is retrieved from a file (currently being the scarb artifacts). But this is for a next PR.