Skip to content

Commit

Permalink
Increase delay for drift detection, not "undiscovable" state.
Browse files Browse the repository at this point in the history
  • Loading branch information
jmalloc committed Jan 12, 2024
1 parent 0a9a3a9 commit 119f56a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ The format is based on [Keep a Changelog], and this project adheres to

<!-- REMEMBER TO BUMP THE VERSIONS IN THE CHART FILE -->

## [0.4.13] - 2024-01-12

### Fixed

- Decrease "drift detection" frequency only, still check again quickly after a
failed discovery.

## [0.4.12] - 2024-01-12

### Changed
Expand Down Expand Up @@ -183,6 +190,7 @@ The format is based on [Keep a Changelog], and this project adheres to
[0.4.10]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.10
[0.4.11]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.11
[0.4.12]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.12
[0.4.13]: https://github.com/dogmatiq/proclaim/releases/tag/v0.4.13

<!-- version template
## [0.0.1] - YYYY-MM-DD
Expand Down
4 changes: 2 additions & 2 deletions charts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: proclaim
description: A Kubernetes controller and CRD that publishes DNS-SD records.
type: application
version: v0.4.12
appVersion: v0.4.12
version: v0.4.13
appVersion: v0.4.13
icon: https://dogmatiq.io/res/img/icon-144x144.png
4 changes: 2 additions & 2 deletions reconciler/advertise.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func (r *Reconciler) requeueResult(
reason = "resource updated since last advertised"
} else if d.Status == metav1.ConditionTrue {
reason = "drift detection"
delay = res.Spec.Instance.TTL.Duration
delay = 10 * res.Spec.Instance.TTL.Duration
} else if discoveredTTL == 0 {
// We have no TTL information from actual DNS records, so we compute
// something based on the TTL.
Expand All @@ -186,7 +186,7 @@ func (r *Reconciler) requeueResult(
// should wait before re-trying. It would be better if the provider
// could give us retry intervals based on the zone's SOA record (e.g.
// negative cache times) and/or API rate limiting.
delay = 10 * res.Spec.Instance.TTL.Duration
delay = res.Spec.Instance.TTL.Duration
reason = "not discoverable"
} else {
// Otherwise, we wait long enough for the mismatching discovered DNS
Expand Down

0 comments on commit 119f56a

Please sign in to comment.