Add optimization option --fcombine-load-threshold=XXX
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the rule: --X is for developers option.
doe300
requested changes
Apr 7, 2018
src/optimization/LiteralValues.cpp
Outdated
| @@ -791,7 +791,6 @@ InstructionWalker optimizations::handleUseWithImmediate( | |||
| // and with constant/unsigned, etc.) | |||
| if(localIt->getSingleWriter() != nullptr) | |||
| it->addDecorations(intermediate::forwardDecorations(localIt->getSingleWriter()->decoration)); | |||
| it.nextInBlock(); | |||
| op->replaceLocal(oldLocal, tmp.local, LocalUse::Type::READER); | |||
There was a problem hiding this comment.
Why did you remove this instruction here? Was it a bug?
There was a problem hiding this comment.
This is a bug. Fixed.
src/main.cpp
Outdated
| if(buffer == name) | ||
| { | ||
| std::getline(ss, buffer, '='); | ||
| if(name == buffer) |
There was a problem hiding this comment.
Why do you re-test for the name?
I think it would be more obvious what is tested here if you reset buffer to an empty string and here test for the buffer still being empty.
There was a problem hiding this comment.
If input is --fcombine-load-threshold (just this, not including '='), ss reach the end. Then second std::getline do nothing. To detect it, name == buffer is needed here.
I add comments about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #67.
This pullreq add
--fcombine-load-thresholdto adjust the threshold ofCombineLoadingLiterals.The impact of the optimization is huge (which is discussed in #67), users may specify the threshold.
It's better to control it by the compiler, but now there is no good way.
The naming rule is as follows: