Skip to content

Commit

Permalink
Deprecate all symbols in the Doctrine\Common\Proxy namespace
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolas-grekas committed Jul 31, 2023
1 parent bd3bdee commit d2ed793
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 14 deletions.
10 changes: 1 addition & 9 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,15 @@ parameters:
-
message: '#^Result of method Doctrine\\Tests\\Common\\Proxy\\LazyLoadableObjectWithVoid::(adding|incrementing)AndReturningVoid\(\) \(void\) is used\.$#'
path: 'tests/Common/Proxy/ProxyLogicVoidReturnTypeTest.php'
-
message: '#^Property Doctrine\\Tests\\Common\\Proxy\\ProxyLogicTest::\$initializerCallbackMock \(callable\(\): mixed&PHPUnit\\Framework\\MockObject\\MockObject\) does not accept PHPUnit\\Framework\\MockObject\\MockObject&stdClass\.$#'
path: 'tests/Common/Proxy/ProxyLogicTest.php'
-
message: '#.*LazyLoadableObject.*#'
paths:
- 'tests/Common/Proxy/ProxyLogicTest.php'
- 'tests/Common/Proxy/ProxyLogicVoidReturnTypeTest.php'
path: 'tests/Common/Proxy/ProxyLogicTest.php'
-
message: '#^Instantiated class Doctrine\\Tests\\Common\\ProxyProxy\\__CG__\\Doctrine\\Tests\\Common\\Proxy\\.* not found.$#'
path: 'tests/Common/Proxy/ProxyLogicTest.php'
-
message: '#^Instantiated class Doctrine\\Tests\\Common\\ProxyProxy\\__CG__\\Doctrine\\Tests\\Common\\Proxy\\.* not found.$#'
path: 'tests/Common/Proxy/ProxyLogicVoidReturnTypeTest.php'
-
message: '#^Property Doctrine\\Tests\\Common\\Proxy\\ProxyLogicVoidReturnTypeTest::\$initializerCallbackMock \(callable\(\): mixed&PHPUnit\\Framework\\MockObject\\MockObject\) does not accept PHPUnit\\Framework\\MockObject\\MockObject&stdClass\.$#'
path: 'tests/Common/Proxy/ProxyLogicVoidReturnTypeTest.php'
-
message: '#^Method Doctrine\\Tests\\Common\\Proxy\\MagicIssetClassWithInteger::__isset\(\) should return bool but returns int\.$#'
path: 'tests/Common/Proxy/MagicIssetClassWithInteger.php'
Expand Down
2 changes: 2 additions & 0 deletions src/Proxy/AbstractProxyFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

/**
* Abstract factory for proxy objects.
*
* @deprecated The AbstractProxyFactory class is deprecated since doctrine/common 3.5.
*/
abstract class AbstractProxyFactory
{
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy/Autoloader.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* Special Autoloader for Proxy classes, which are not PSR-0 compliant.
*
* @internal
* @deprecated The Autoloader class is deprecated since doctrine/common 3.5.
*/
class Autoloader
{
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy/Exception/InvalidArgumentException.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/**
* Proxy Invalid Argument Exception.
*
* @link www.doctrine-project.org
* @deprecated The InvalidArgumentException class is deprecated since doctrine/common 3.5.
*/
class InvalidArgumentException extends BaseInvalidArgumentException implements ProxyException
{
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy/Exception/OutOfBoundsException.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* Proxy Invalid Argument Exception.
*
* @link www.doctrine-project.org
* @deprecated The OutOfBoundsException class is deprecated since doctrine/common 3.5.
*/
class OutOfBoundsException extends BaseOutOfBoundsException implements ProxyException
{
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy/Exception/ProxyException.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* Base exception interface for proxy exceptions.
*
* @link www.doctrine-project.org
* @deprecated The ProxyException interface is deprecated since doctrine/common 3.5.
*/
interface ProxyException
{
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy/Exception/UnexpectedValueException.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* Proxy Unexpected Value Exception.
*
* @link www.doctrine-project.org
* @deprecated The UnexpectedValueException class is deprecated since doctrine/common 3.5.
*/
class UnexpectedValueException extends BaseUnexpectedValueException implements ProxyException
{
Expand Down
2 changes: 2 additions & 0 deletions src/Proxy/Proxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
/**
* Interface for proxy classes.
*
* @deprecated The Proxy interface is deprecated since doctrine/common 3.5.
*
* @template T of object
* @template-extends BaseProxy<T>
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Proxy/ProxyDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

/**
* Definition structure how to create a proxy.
*
* @deprecated The ProxyDefinition class is deprecated since doctrine/common 3.5.
*/
class ProxyDefinition
{
Expand Down
3 changes: 3 additions & 0 deletions src/Proxy/ProxyGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Doctrine\Common\Proxy\Exception\InvalidArgumentException;
use Doctrine\Common\Proxy\Exception\UnexpectedValueException;
use Doctrine\Common\Util\ClassUtils;
use Doctrine\Deprecations\Deprecation;

Check failure on line 9 in src/Proxy/ProxyGenerator.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (7.4)

Type Doctrine\Deprecations\Deprecation is not used in this file.
use Doctrine\Persistence\Mapping\ClassMetadata;
use ReflectionIntersectionType;
use ReflectionMethod;
Expand Down Expand Up @@ -67,6 +68,8 @@
/**
* This factory is used to generate proxy classes.
* It builds proxies from given parameters, a template and class metadata.
*
* @deprecated The ProxyGenerator class is deprecated since doctrine/common 3.5.
*/
class ProxyGenerator
{
Expand Down

0 comments on commit d2ed793

Please sign in to comment.